feat(locale): add Serbian (Latin) language #1801

bdimitrovski · 2023-01-31T02:27:26Z

No description provided.

ejcheng

Please remove the duplicated values in your locale data as shown here

https://github.com/faker-js/faker/actions/runs/4050174605/jobs/6967813401

bdimitrovski · 2023-01-31T08:43:02Z

@import-brain Done, the tests should be passing now.

codecov · 2023-01-31T09:05:22Z

Codecov Report

Merging #1801 (93e123f) into next (93e1433) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 93e123f differs from pull request most recent head 6a5c268. Consider uploading reports for the commit 6a5c268 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1801      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2354     2385      +31     
  Lines      236555   239261    +2706     
  Branches     1227     1226       -1     
==========================================
+ Hits       235673   238363    +2690     
- Misses        860      876      +16     
  Partials       22       22

Impacted Files	Coverage Δ
src/locale/index.ts	`100.00% <100.00%> (ø)`
src/locale/sr_RS_latin.ts	`100.00% <100.00%> (ø)`
src/locales/index.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/cell_phone/formats.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/cell_phone/index.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/date/index.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/date/month.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/date/weekday.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/index.ts	`100.00% <100.00%> (ø)`
src/locales/sr_RS_latin/internet/domain_suffix.ts	`100.00% <100.00%> (ø)`
... and 20 more

... and 11 files with indirect coverage changes

src/locales/sr_RS/date/month.ts

src/locales/sr_RS/date/weekday.ts

src/locales/sr_RS/person/last_name.ts

src/locales/sr_RS/person/name.ts

bdimitrovski · 2023-02-06T11:00:10Z

@matthewmayer @ST-DDT when could we expect this to land?

matthewmayer · 2023-02-06T12:32:04Z

Probably best to use your own fork if you are relying on its functionality in the short term.

https://blaipratdesaba.com/how-to-use-an-npm-node-module-that-has-been-forked-b7dd522fdd08

Even when it lands it will only be going into 8.0.0 which is still in alpha.

ST-DDT · 2023-02-09T00:08:44Z

We are currently busy and thus are a little bit slower with the reviews.
AFAIK neither of us has any Serbian skills, so it takes a bit of time for us to review.
We will review/merge it when we have time, probably soon.
You can speed up the process by getting reviews from a third-party.

As for a release, we might release another v8 alpha in the next month (not sure yet),
but the actual v8 stable release will take at least one or two months.

Also I noticed, that there are two "Serbian" languages, that seem to have the same locale code.

sr-RS@latin + sr-RS (Russian characters + some more?)

https://github.com/validatorjs/validator.js/blob/master/src/lib/alpha.js#L24-L25

I'm not sure what the correct locale code would be here.
Can you give us some insides on this issue? Should we use sr_RS_latin as locale code for clarification?

bdimitrovski · 2023-02-09T09:54:39Z

We are currently busy and thus are a little bit slower with the reviews. AFAIK neither of us has any Serbian skills, so it takes a bit of time for us to review. We will review/merge it when we have time, probably soon. You can speed up the process by getting reviews from a third-party.

As for a release, we might release another v8 alpha in the next month (not sure yet), but the actual v8 stable release will take at least one or two months.

Also I noticed, that there are two "Serbian" languages, that seem to have the same locale code.

sr-RS@latin + sr-RS (Russian characters + some more?)

https://github.com/validatorjs/validator.js/blob/master/src/lib/alpha.js#L24-L25

I'm not sure what the correct locale code would be here. Can you give us some insides on this issue? Should we use sr_RS_latin as locale code for clarification?

That's alright, I understand that you're busy, however, these are mostly just Serbian names, cities and some addresses, nothing fancy.

You can use the sr_RS_latin code, as we also have the Cyrilic alphabet, however, I have not translated it on this occasion. I can add it in another iteration, however, Latin would be more of a priority at this point.

matthewmayer · 2023-02-09T13:25:44Z

seems sr_rs_latn and sr_rs_cyrl (or sr_latn_rs,sr_latn_cyrl) are more common in various software which distinguishes the two

matthewmayer · 2023-02-09T13:27:49Z

bit of background https://ciklopea.com/blog/localization/should-you-localize-to-serbian-latin-or-to-serbian-cyrillic/

@bdimitrovski one thing i wasn't totally clear on: can you do a perfect 1-1 transliteration between the Latin and Cyrillic scripts? ie a computer should be able to translate character by characters? Or does it require some context/knowledge

ST-DDT · 2023-02-11T13:04:30Z

seems sr_rs_latn and sr_rs_cyrl (or sr_latn_rs,sr_latn_cyrl) are more common in various software which distinguishes the two

Do you have a source for this?

My search results show otherwise:

https://www.google.com/search?q=%22sr_RS_Latin%22 => 747.000
https://www.google.com/search?q=%22sr_RS_Latn%22 => 55
https://www.google.com/search?q=%22sr-RS-Latin%22 => 5260
https://www.google.com/search?q=%22sr-RS-Latn%22 => 1040

Also I found this entry from the rust sources:

https://docs.rs/pure-rust-locales/0.2.1/x86_64-apple-darwin/pure_rust_locales/sr_RS_latin/LC_TIME/index.html

ST-DDT · 2023-03-07T13:20:40Z

This PR needs to be updated:

git fetch --all
git merge origin/next
pnpm run preflight
git add .
git merge --continue

Shinigami92 · 2023-03-11T19:44:48Z

Should we merge this as is or should we rename it to sr_RS_latin?

A little bit of googling showed that sr_RS_latin is not a bad idea and theoretically "valid"
If another one also says yes, lets do it 👍

bdimitrovski · 2023-03-15T22:34:35Z

@matthewmayer @ST-DDT @Shinigami92 is this ready to go then?

ST-DDT · 2023-03-16T00:17:46Z

We will discuss the locale key tomorrow in our team meeting.

ST-DDT

Team Decision

docs.rs/pure-rust-locales/0.2.1/x86_64-apple-darwin/pure_rust_locales/sr_RS_latin/LC_TIME/index.html

Based on that source we have decided to use sr_RS_latin as locale key.
Please change the locale key accordingly.

bdimitrovski · 2023-03-17T10:04:14Z

sr_RS_latin

@ST-DDT How/where would I change that? Which file(s) should be altered?

matthewmayer · 2023-03-17T10:37:43Z

Basically

rename the whole src/locales/sr_RS to src/locales/sr_RS_latin
do a global text replace from sr_RS to sr_RS_latin
run pnpm run preflight to make sure everything's OK

bdimitrovski · 2023-03-17T10:41:20Z

Basically

rename the whole src/locales/sr_RS to src/locales/sr_RS_latin

do a global text replace from sr_RS to sr_RS_latin

run pnpm run preflight to make sure everything's OK

@matthewmayer Sure thing, that's what my thinking was too. But should I do that even in automatically generated files, like these?

At this point, the sr_RS does not exist anymore, since I've renamed it, but when I run pnpm run preflight it still generates that.

matthewmayer · 2023-03-17T10:42:19Z

Basically

rename the whole src/locales/sr_RS to src/locales/sr_RS_latin

do a global text replace from sr_RS to sr_RS_latin

run pnpm run preflight to make sure everything's OK

@matthewmayer Sure thing, that's what my thinking was too. But should I do that even in automatically generated files, like these?

doesn't really matter, they'll get regenerated by pnpm run preflight anyway.

bdimitrovski · 2023-03-17T10:46:00Z

@matthewmayer @ST-DDT all done.

src/locale/sr_RS.ts

bdimitrovski · 2023-03-17T13:43:12Z

bit of background https://ciklopea.com/blog/localization/should-you-localize-to-serbian-latin-or-to-serbian-cyrillic/

@bdimitrovski one thing i wasn't totally clear on: can you do a perfect 1-1 transliteration between the Latin and Cyrillic scripts? ie a computer should be able to translate character by characters? Or does it require some context/knowledge

Sorry, I've only seen this now - as for the transliteration, yes, it is possible - you can see it in action here https://www.lexilogos.com/keyboard/serbian_conversion.htm

Serbian language is the only European language to use a 2 way lettering system (otherwise known as full synchronic digraphia), the Cyrillic letter is in formal use (government, documents, etc), while informally, almost everyone uses Latin, in everyday communication.

Automatic transliteration to Cyrillic of the work that I've done for the Latin letter, is possible (again, referring to e.g. lexilogos.com):

(feat): add Serbian (Latin) language

f81f33c

bdimitrovski requested a review from a team January 31, 2023 02:27

bdimitrovski requested a review from a team as a code owner January 31, 2023 02:27

bdimitrovski mentioned this pull request Jan 31, 2023

Letter "Đ" in latin while using the hr locale is incorrect #1800

Closed

10 tasks

Merge branch 'next' into feature/add-rs-locale

3d023cc

ejcheng assigned bdimitrovski Jan 31, 2023

ejcheng added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jan 31, 2023

ejcheng added this to the v8 - None milestone specific tasks milestone Jan 31, 2023

ejcheng reviewed Jan 31, 2023

View reviewed changes

removes duped city and surname entries, sort

da3e04f

matthewmayer requested changes Jan 31, 2023

View reviewed changes

bdimitrovski and others added 3 commits January 31, 2023 23:11

Fixes as per comments

8c4ef4a

Reduce rs surname pool to 1K

f50b2f0

Merge branch 'next' into feature/add-rs-locale

a391190

Shinigami92 reviewed Feb 2, 2023

View reviewed changes

src/locales/sr_RS/person/name.ts Outdated Show resolved Hide resolved

bdimitrovski and others added 2 commits February 6, 2023 09:56

Add weighted objects

1656720

Merge branch 'next' into feature/add-rs-locale

e6256b3

Shinigami92 requested a review from matthewmayer February 24, 2023 11:56

ST-DDT added the needs rebase There is a merge conflict label Mar 7, 2023

ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 16, 2023

ST-DDT requested changes Mar 16, 2023

View reviewed changes

ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Mar 16, 2023

Replaces sr_RS with sr_RS_latin

878e050

bdimitrovski dismissed stale reviews from Shinigami92 and matthewmayer via 878e050 March 17, 2023 10:45

Merge branch 'next' into feature/add-rs-locale

cfe5942

ST-DDT reviewed Mar 17, 2023

View reviewed changes

src/locale/sr_RS.ts Outdated Show resolved Hide resolved

Delete sr_RS.ts

5ec5633

ST-DDT approved these changes Mar 17, 2023

View reviewed changes

ST-DDT requested review from matthewmayer, ejcheng, Shinigami92 and a team March 17, 2023 22:25

Merge branch 'next' into feature/add-rs-locale

93e123f

Shinigami92 approved these changes Mar 18, 2023

View reviewed changes

ST-DDT enabled auto-merge (squash) March 20, 2023 18:47

Merge branch 'next' into feature/add-rs-locale

6a5c268

ST-DDT merged commit d2046e8 into faker-js:next Mar 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(locale): add Serbian (Latin) language #1801

feat(locale): add Serbian (Latin) language #1801

bdimitrovski commented Jan 31, 2023

ejcheng left a comment

bdimitrovski commented Jan 31, 2023

codecov bot commented Jan 31, 2023 •

edited

Loading

bdimitrovski commented Feb 6, 2023

matthewmayer commented Feb 6, 2023

ST-DDT commented Feb 9, 2023

bdimitrovski commented Feb 9, 2023

matthewmayer commented Feb 9, 2023

matthewmayer commented Feb 9, 2023

ST-DDT commented Feb 11, 2023

ST-DDT commented Mar 7, 2023

Shinigami92 commented Mar 11, 2023

bdimitrovski commented Mar 15, 2023

ST-DDT commented Mar 16, 2023

ST-DDT left a comment

bdimitrovski commented Mar 17, 2023

matthewmayer commented Mar 17, 2023 •

edited

Loading

bdimitrovski commented Mar 17, 2023 •

edited

Loading

matthewmayer commented Mar 17, 2023

bdimitrovski commented Mar 17, 2023

bdimitrovski commented Mar 17, 2023

feat(locale): add Serbian (Latin) language #1801

feat(locale): add Serbian (Latin) language #1801

Conversation

bdimitrovski commented Jan 31, 2023

ejcheng left a comment

Choose a reason for hiding this comment

bdimitrovski commented Jan 31, 2023

codecov bot commented Jan 31, 2023 • edited Loading

Codecov Report

bdimitrovski commented Feb 6, 2023

matthewmayer commented Feb 6, 2023

ST-DDT commented Feb 9, 2023

bdimitrovski commented Feb 9, 2023

matthewmayer commented Feb 9, 2023

matthewmayer commented Feb 9, 2023

ST-DDT commented Feb 11, 2023

ST-DDT commented Mar 7, 2023

Shinigami92 commented Mar 11, 2023

bdimitrovski commented Mar 15, 2023

ST-DDT commented Mar 16, 2023

ST-DDT left a comment

Choose a reason for hiding this comment

bdimitrovski commented Mar 17, 2023

matthewmayer commented Mar 17, 2023 • edited Loading

bdimitrovski commented Mar 17, 2023 • edited Loading

matthewmayer commented Mar 17, 2023

bdimitrovski commented Mar 17, 2023

bdimitrovski commented Mar 17, 2023

codecov bot commented Jan 31, 2023 •

edited

Loading

matthewmayer commented Mar 17, 2023 •

edited

Loading

bdimitrovski commented Mar 17, 2023 •

edited

Loading