-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(docs): add docs diff script #1755
Conversation
Blocked by #859 |
Here a preview for the api hash json: https://docs-diff-notification--serene-sprite-f3ef50.netlify.app/api-diff-index.json |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1755 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2346 2346
Lines 235002 235002
Branches 1132 1129 -3
==========================================
- Hits 234149 234127 -22
- Misses 831 853 +22
Partials 22 22
|
Also blocked by #1759 |
Waiting for #1757 to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve for now to not block it, but theoretically you could think about to improve this much by using js URL
class
Even file://
seems to be supported, and this way you could extract and handle stuff more precise like line 38 source.startsWith('https://')
could become source.protocol === 'https:'
but you could also do this in a new PR and iterate
cacd5e7
3d3ca57
Fixes #1754
Adds CI notification about changed api doc pages.
Embed into CIWill be done in a later PR