Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): change country name from Holanda to official name #1668

Closed
wants to merge 1 commit into from
Closed

fix(locale): change country name from Holanda to official name #1668

wants to merge 1 commit into from

Conversation

marcosvidolin
Copy link
Contributor

Changing the country name from Holland to the official name Netherlands

@marcosvidolin marcosvidolin requested a review from a team as a code owner December 16, 2022 20:20
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Dec 16, 2022
@Shinigami92 Shinigami92 changed the title refactor(name): change country name from Holanda to official name fix(locale): change country name from Holanda to official name Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1668 (f16bed5) into next (b7dbfac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1668   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files        2222     2222           
  Lines      240133   240133           
  Branches     1050     1055    +5     
=======================================
+ Hits       239261   239285   +24     
+ Misses        851      827   -24     
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/es/location/country.ts 100.00% <100.00%> (ø)
src/locales/es_MX/location/country.ts 100.00% <100.00%> (ø)
src/locales/pt_BR/location/country.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 90.54% <0.00%> (+6.48%) ⬆️

@ST-DDT ST-DDT requested review from a team December 16, 2022 23:12
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 16, 2022
@marcosvidolin marcosvidolin closed this by deleting the head repository Dec 17, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Dec 17, 2022

@marcosvidolin Is there a reason why you deleted the PR? Should we still try to merge it?

@marcosvidolin
Copy link
Contributor Author

Sorry guys, my mistake.
here is the new one: #1669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants