feat(number): adjust hex default #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1649 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.02%
==========================================
Files 2221 2221
Lines 240108 240108
Branches 1054 1049 -5
==========================================
- Hits 239261 239236 -25
- Misses 826 851 +25
Partials 21 21
|
ST-DDT
approved these changes
Dec 9, 2022
I think no, as this is a new function in v8 and the old is not touched |
xDivisionByZerox
approved these changes
Dec 10, 2022
ejcheng
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on
I found that the hex default max are off by 1
We wanted to generate numbers from 0-f and so on, but the +16 instead of +15 generated 0-10 instead