remove dead code in commerce module

[xDivisionByZerox]

Clear and concise description of the problem

Thecommerce module has a lot of dead code in it that is marked with a TODO to remove it.

faker/src/commerce.ts

Lines 92 to 118 in 877ac76

	// TODO @Shinigami92 2022-01-12: unimplemented member functions
	/*
	categories (num) {
	var categories = [];
	do {
	var category = this.faker.random.arrayElement(this.faker.definitions.commerce.department);
	if(categories.indexOf(category) === -1) {
	categories.push(category);
	}
	} while(categories.length < num);
	return categories;
	};
	*/
	/*
	mergeCategories (categories) {
	var separator = this.faker.definitions.separator || " &";
	// TODO: find undefined here
	categories = categories || this.faker.definitions.commerce.categories;
	var commaSeparated = categories.slice(0, -1).join(', ');
	return [commaSeparated, categories[categories.length - 1]].join(separator + " ");
	};
	*/

Suggested solution

Remove the dead code.

Alternative

No response

Additional context

No response

[Shinigami92]

IMO this can removed right now, cause it will not touch the runtime code in any way

[xDivisionByZerox]

But it's not a bugfix by definition. But if the majority of maintainers are fine with it being removed right away I will not say anything.

[ST-DDT]

We also do a lot of other cleanup so it's ok to be in v6.1

[rimakan]

hey! is the issue still actual? could I take it please?

[xDivisionByZerox]

Sure go ahead. I'll assign you to it.

[rimakan]

@xDivisionByZerox , added a PR #745, could you please check it out?