infra: check test snapshots to be up to date (#1632)

faker-js · Dec 7, 2022 · f1948bd · f1948bd
1 parent 97dbfa1
commit f1948bd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/.github/workflows/commentCodeGeneration.ts b/.github/workflows/commentCodeGeneration.ts
@@ -21,7 +21,7 @@ module.exports = async (
     issue_number: context.issue.number,
   });
 
-  const body = `Uncommitted changes were detected after runnning <code>generate:*</code> commands.\nPlease run <code>pnpm run generate:locales</code> and <code>pnpm run generate:api-docs</code> to generate/update the related files, and commit them.`;
+  const body = `Uncommitted changes were detected after runnning <code>generate:*</code> commands.\nPlease run <code>pnpm run generate:locales</code>, <code>pnpm run generate:api-docs</code>, and <code>pnpm run test -u</code> to generate/update the related files, and commit them.`;
 
   const botComment = comments.find(
     (comment) => comment.user?.type === 'Bot' && comment.body?.includes(body)

diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -38,6 +38,8 @@ jobs:
         run: |
           pnpm run generate:locales
           pnpm run generate:api-docs
+          pnpm run build
+          pnpm run test -u
 
       - name: Check diff
         id: diff

diff --git a/test/__snapshots__/internet.spec.ts.snap b/test/__snapshots__/internet.spec.ts.snap
@@ -22,8 +22,6 @@ exports[`internet > 42 > displayName > with Latin names 1`] = `"Jane_Doe"`;
 
 exports[`internet > 42 > displayName > with accented names 1`] = `"Hélene_Müller"`;
 
-exports[`internet > 42 > displayName > with names 1`] = `"Jane_Doe"`;
-
 exports[`internet > 42 > domainName 1`] = `"hasty-shin.org"`;
 
 exports[`internet > 42 > domainSuffix 1`] = `"info"`;
@@ -94,8 +92,6 @@ exports[`internet > 42 > userName > with Latin names 1`] = `"Jane_Doe"`;
 
 exports[`internet > 42 > userName > with accented names 1`] = `"Helene_Muller"`;
 
-exports[`internet > 42 > userName > with names 1`] = `"Jane_Doe"`;
-
 exports[`internet > 1211 > avatar 1`] = `"https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/1160.jpg"`;
 
 exports[`internet > 1211 > color > noArgs 1`] = `"#773a72"`;
@@ -118,8 +114,6 @@ exports[`internet > 1211 > displayName > with Latin names 1`] = `"Jane.Doe89"`;
 
 exports[`internet > 1211 > displayName > with accented names 1`] = `"Hélene.Müller89"`;
 
-exports[`internet > 1211 > displayName > with names 1`] = `"Jane.Doe89"`;
-
 exports[`internet > 1211 > domainName 1`] = `"vibrant-infix.org"`;
 
 exports[`internet > 1211 > domainSuffix 1`] = `"org"`;
@@ -190,8 +184,6 @@ exports[`internet > 1211 > userName > with Latin names 1`] = `"Jane.Doe89"`;
 
 exports[`internet > 1211 > userName > with accented names 1`] = `"Helene.Muller89"`;
 
-exports[`internet > 1211 > userName > with names 1`] = `"Jane.Doe89"`;
-
 exports[`internet > 1337 > avatar 1`] = `"https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/327.jpg"`;
 
 exports[`internet > 1337 > color > noArgs 1`] = `"#214814"`;
@@ -214,8 +206,6 @@ exports[`internet > 1337 > displayName > with Latin names 1`] = `"Jane56"`;
 
 exports[`internet > 1337 > displayName > with accented names 1`] = `"Hélene56"`;
 
-exports[`internet > 1337 > displayName > with names 1`] = `"Jane56"`;
-
 exports[`internet > 1337 > domainName 1`] = `"fair-migration.com"`;
 
 exports[`internet > 1337 > domainSuffix 1`] = `"biz"`;
@@ -285,5 +275,3 @@ exports[`internet > 1337 > userName > with Cyrillic names 1`] = `"Fedor56"`;
 exports[`internet > 1337 > userName > with Latin names 1`] = `"Jane56"`;
 
 exports[`internet > 1337 > userName > with accented names 1`] = `"Helene56"`;
-
-exports[`internet > 1337 > userName > with names 1`] = `"Jane56"`;