Merge branch 'fix-npm'

factorial-io · Dec 3, 2024 · 9bb6182 · 9bb6182
2 parents 66f5353 + 349cc64
commit 9bb6182
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -96,6 +96,13 @@ All notable changes to this project will be documented in this file. See [standa
 * Upgrade dependencies
 * Remove deprecated code
 
+### [3.8.35](https://github.com/factorial-io/phabalicious/compare/3.8.34...3.8.35) (2024-12-03)
+
+
+### Bug Fixes
+
+* Fix for npm-method for not picking up the build command setting (Fixes [#351](https://github.com/factorial-io/phabalicious/issues/351)) ([52c7250](https://github.com/factorial-io/phabalicious/commit/52c7250c431c10c3df36300869a1eb98dbf41a6d))
+
 ### [3.8.34](https://github.com/factorial-io/phabalicious/compare/3.8.33...3.8.34) (2024-11-11)
 
 ### Bug Fixes

diff --git a/src/Method/NpmMethod.php b/src/Method/NpmMethod.php
@@ -55,7 +55,7 @@ public function validateConfig(
     public function resetPrepare(HostConfig $host_config, TaskContextInterface $context)
     {
         $this->runCommand($host_config, $context, 'install');
-        $this->runCommand($host_config, $context, $host_config->get('npmBuildCommand'));
+        $this->runCommand($host_config, $context, $host_config->getProperty('npm.buildCommand'));
     }
 
     public function installPrepare(HostConfig $host_config, TaskContextInterface $context)