Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another improvement to TS type checking #85

Merged
merged 1 commit into from
Dec 3, 2017

Conversation

forabi
Copy link
Contributor

@forabi forabi commented Dec 2, 2017

export const LoadableNotablePerson = universal(import('./NotablePerson'), {
  key: 'NotablePerson',
});

If key is a string, it must be a key of the export module object. This helps avoid typos.

@faceyspacey
Copy link
Owner

Do you mind doing these commits with the script, npm run cm. Then it auto publishes to npm once merged :)

If key is a string, it must be a key of the export module object. This helps avoid typos.
@forabi
Copy link
Contributor Author

forabi commented Dec 3, 2017

Ah, sorry, I was using GitHub's UI to make the changes. I force-pushed the new commit to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants