-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update compatibility to a recent Triton #483
Conversation
56027bc
to
0fd2fe8
Compare
48c8d23
to
17722fb
Compare
17722fb
to
4926774
Compare
Oh that's great! Thanks for the contribution! I gave it a try in #521 by simply changing the requirements.txt file, but it looks like there is more to it |
adding a basic triton random check switching all the asserts in triton fused linear layer to triton's
f6d08e3
to
f4cb19f
Compare
f4cb19f
to
6a294d6
Compare
yes, some of the interface changed (you cannot compose kernels anymore for instance). It should work with more recent versions I believe, this is post-breaking changes |
Codecov ReportBase: 88.05% // Head: 88.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 88.05% 88.02% -0.04%
==========================================
Files 80 80
Lines 4823 4817 -6
==========================================
- Hits 4247 4240 -7
- Misses 576 577 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Happy to review/merge once you think it's ready :)
ouch, the latest update doesn't work on a T4 used for CI, too old.. I'll fix that later when I get the time :( |
Do you think we can merge it without the latest changes? As this is currently blocking users from installing xformers with triton at all |
it's just a dimension preset on the fused linear kernel, I'll update that |
c8f656d
to
b9998c4
Compare
- adding the new plots
b9998c4
to
99e4a86
Compare
…ocessing bigger BLOCK_Ns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for maintaining the triton part of the code and updating it!
Really appreciated :)
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.