[feat][minor] Simplicial embeddings #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #259, adds simplicial embeddings + option to add it at the bottom of an encoder. I actually don't believe that it's super important (it was kind of easy to add manually beforehand), but it does not take much space (orthogonal to the rest), and I would be curious to see how that affects things like openclip and friends.
I've done a dummy test on the ViT Cifar training, it does not meaningfully affects the score (in either way), which is not too surprising (the linear probe afterwards could already recover from "misaligned" dimensions given the strong supervised signal, which is what simplicial embeddings could improve)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.