[CI][fix] seed third party removal

[blefaudeux]

What does this PR do?

Not actually needed since isort 5.. Fixes #194
I just checked with a brand new environment, no problem on my side

Before submitting

• Did you have fun?
  • Make sure you had fun coding 🙃
• Did you read the contributor guideline?
• Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • N/A
• Did you make sure to update the docs?
  • N/A
• Did you write any new necessary tests?
  • N/A
• Did you update the changelog? (if needed)
  • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

[codecov-commenter]

Codecov Report

Merging #201 (704f2c2) into main (73d8f7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          59       59           
  Lines        2996     2996           
=======================================
  Hits         2742     2742           
  Misses        254      254           

Flag	Coverage Δ
Python	91.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d8f7f...704f2c2. Read the comment docs.

[fmassa]

Thanks!

FYI I'm using isort 5.7.0 and I face this issue without this patch

[blefaudeux]

Thanks!

FYI I'm using isort 5.7.0 and I face this issue without this patch

with the log you reported ? It should not be possible, this extension is not here anymore.. but what probably happens is that you need to remove pre-commit and re-install it (it only reads the config once, at installation time). I did test the above in a blank env and no problemo

edit: no ok, I probably misunderstood your comment. So basically (a) pre-commit needs to be uninstalled then installed again for this to be picked up (b) your point was that you were facing the issue with isort 5.7, yes, I meant in the PR comment to say that we could remove this step because isort >5 was doing it already (which is probably why this seed-third-party tool was deprecated in the first place). So all in all this should fix your case and not remove any existing feature !