Change recommend to raise an error in MOO case #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…research/nevergrad into theoajc/update_cb_tests
…into update_recoms
jrapin
reviewed
Aug 18, 2021
nevergrad/optimization/base.py
Outdated
| @@ -518,6 +518,8 @@ def recommend(self) -> p.Parameter: | |||
| The candidate with minimal loss. :code:`p.Parameters` have field :code:`args` and :code:`kwargs` which can be directly used | |||
| on the function (:code:`objective_function(*candidate.args, **candidate.kwargs)`). | |||
| """ | |||
| if self.num_objectives > 1: | |||
| raise RuntimeError("No best candidate in MOO.") | |||
There was a problem hiding this comment.
might be helpful to tell the user to use the pareto_front function instead, so that they dont get lost
There was a problem hiding this comment.
"No best candidate in MOO. Use pareto_front function instead to get the set of all non-dominated candidates."
How is that?
jrapin
approved these changes
Aug 20, 2021
Co-authored-by: Jérémy Rapin <jrapin.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Make recommend raise an error when doing MOO because during MOO there is no best candidate to recommend so not appropriate.
How Has This Been Tested (if it applies)
Ensure all tests that this change broke passed by making small changes elsewhere when necessary (i.e. to minimize).
Checklist