Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Upgrade to PyTorch 1.2.0 #76

Closed
apsdehal opened this issue May 29, 2019 · 5 comments
Closed

[enhancement] Upgrade to PyTorch 1.2.0 #76

apsdehal opened this issue May 29, 2019 · 5 comments
Assignees
@apsdehal
Labels
enhancement New feature or request

Comments

@apsdehal
Copy link
Contributor

There are some issues related to flatten_parameters that are currently preventing this upgrade. I am looking into this.
@apsdehal apsdehal self-assigned this May 29, 2019
@apsdehal apsdehal added the enhancement New feature or request label May 29, 2019
@apsdehal
Copy link
Contributor Author

Blocked by pytorch/pytorch#21108 for now.

@mrshenli mrshenli mentioned this issue May 31, 2019
Closed
@vedanuj
Copy link
Contributor

vedanuj commented Aug 8, 2019

Pytorch 1.2 Stable is released today. We can update pythia to use 1.2 now. I have been testing with 1.2 nightly and haven't found any issues till now.

@apsdehal
Copy link
Contributor Author

apsdehal commented Aug 8, 2019

Yup, I have been actually working on this and a lot of other relevant fixes.

@apsdehal
Copy link
Contributor Author

apsdehal commented Aug 10, 2019 •
edited
Loading

Related pytorch/pytorch#24137. Breaks the early stopping mechanism.

@apsdehal apsdehal changed the title [enhancement] Upgrade to PyTorch 1.1.0 [enhancement] Upgrade to PyTorch 1.2.0 Aug 10, 2019
@apsdehal apsdehal mentioned this issue Aug 27, 2019
Merged
@vedanuj
Copy link
Contributor

vedanuj commented Jan 16, 2020

Upgrade next to Pytorch 1.4

apsdehal added a commit that referenced this issue May 8, 2020
@apsdehal @facebook-github-bot
[fix] Seeding fixes, seed random, generate strong seed (#76)
addc221 
Summary: Pull Request resolved: fairinternal/mmf-internal#76

Reviewed By: vedanuj

Differential Revision: D21105265

Pulled By: apsdehal

fbshipit-source-id: 4f991a81a9614bf4ff2536fe7aff6dac7e2b341a
apsdehal added a commit that referenced this issue May 8, 2020
@apsdehal
[fix] Seeding fixes, seed random, generate strong seed (#76)
82fd8cd 
Summary: Pull Request resolved: https://github.com/fairinternal/pythia-internal/pull/76

Reviewed By: vedanuj

Differential Revision: D21105265

Pulled By: apsdehal

fbshipit-source-id: 4f991a81a9614bf4ff2536fe7aff6dac7e2b341a
@apsdehal apsdehal closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apsdehal apsdehal

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apsdehal @vedanuj