Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C API] June 2019 update #869

Merged
merged 4 commits into from
Jun 24, 2019
Merged

[C API] June 2019 update #869

merged 4 commits into from
Jun 24, 2019

Conversation

Enet4
Copy link
Contributor

@Enet4 Enet4 commented Jun 21, 2019

This is a set of changes to adapt the C API to the latest major updates. Quick summary:

  • Update Makefiles in c_api to include the relevant flags from makefile.inc
  • Type changes: use idx_t or size_t where appropriate instead of long
  • Remove a redundant declaration of FaissIndexIVF

Enet4 added 4 commits June 21, 2019 11:18
@Enet4
[c_api] use all relevant flags in compilation
9785966
@Enet4
[c_api] Remove redundant IndexIVFFlat declarations
0e00d12 
- From IndexIVF_c.h, already declared in IndexIVFFlat_c.h
@Enet4
[c_api] type changes
4a4750d 
- replace `long` with a more suitable type
- provide definitions for `faiss_component_t` and `faiss_distance_t`
@Enet4
[c_api] Define CFLAGS and CUDACFLAGS
3086c46
@beauby
Copy link
Contributor

beauby commented Jun 24, 2019

Thanks @Enet4 – merging.

@beauby beauby merged commit 828dcea into facebookresearch:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enet4 @beauby @facebook-github-bot