Benchmarking Scripts for cuVS Index, more docs updates #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tarang-jain
commented
Jan 3, 2025
•
- Small updates to FAISS + cuVS docs.
- Fixes IVF-Flat and IVF-PQ benchmarking scripts.
- Re-enable cuVS backend in gpu python tests
Fetch upstream main
|
Looks like you also need to remove the error message in GpuIndexIVFPQ.cu: https://github.com/facebookresearch/faiss/actions/runs/12860778246/job/35853553529?pr=4117#step:3:4157 |
) Summary: This pull request introduces a new default argument, `ngpu=-1`, to the `knn_ground_truth` function in the `faiss.contrib`. ## Purpose of Change ### Bug Fix In the current implementation, running tests under the tests directory (CPU tests) in an environment with faiss-gpu installed would inadvertently use the GPU and cause unintended behavior. This pull request prevents the GPU from being used during CPU-only tests by explicitly controlling GPU allocation via the ngpu parameter. ### API Consistency Other functions that call `faiss.get_num_gpus` in `faiss.contrib`, such as `range_search_max_results` and `range_ground_truth`, already include the `ngpu` argument. Adding this parameter to `knn_ground_truth` will ensure consistency across the API, reduce potential confusion, and improve ease of use. Pull Request resolved: facebookresearch#4123 Reviewed By: asadoughi Differential Revision: D68199506 Pulled By: junjieqi fbshipit-source-id: cb50e206d8a1a982c21b0ccb42825ea45873f3ef
Summary: Pull Request resolved: facebookresearch#4130 same as title Reviewed By: asadoughi Differential Revision: D68388863 fbshipit-source-id: 4ebb38d8454bf95733c918950d7d8d3b22e00d5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.