Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Arm64 support #4087

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Binozo
Copy link

@Binozo Binozo commented Dec 12, 2024

Hey there 👋

currently I am working on a project using faiss using FaissMask (.NET Bindings).
As I am developing on a windows arm64 machine I needed a way to compile faiss for windows arm.
I ran the tests in FaissMask and my little hack seemed valid.

Here is a little script to compile it yourself:

#!/bin/bash
# Execute in git bash
# and cmake (https://cmake.org/download/)
BRANCH="feat/windows-arm64-support"
GITHUB_ACCOUNT=Binozo

git clone --depth=1 --recursive --branch $BRANCH https://github.com/$GITHUB_ACCOUNT/faiss.git
cd faiss
cmake -Wno-dev -DFAISS_ENABLE_GPU=OFF -DFAISS_ENABLE_PYTHON=OFF -DFAISS_ENABLE_C_API=ON -DBUILD_TESTING=OFF -DBUILD_SHARED_LIBS=ON -DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON -DBLA_VENDOR=Intel10_64_dyn "-DMKL_LIBRARIES=C:\Users\<USER>\CLionProjects\OpenBLAS\cmake-build-release\lib\Release\openblas.lib" -B build -S .
cmake --build build --config Release --target faiss faiss_c

(Make sure you compiled OpenBLAS for windows arm64 before and adjust C:\Users\<USER>\CLionProjects\OpenBLAS\cmake-build-release\lib\Release\openblas.lib if needed)

@facebook-github-bot
Copy link
Contributor

Hi @Binozo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@junjieqi
Copy link
Contributor

@Binozo Hi, thank you for making windows arm64 support! Would you mind fix the CI signals? Would be really appreciated it

@Binozo
Copy link
Author

Binozo commented Dec 17, 2024

Sure!

@facebook-github-bot
Copy link
Contributor

@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

return (int)__lzcnt64(x);
#elif defined(_M_ARM64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Binozo This doesn't appear to be Windows specific actually. Does it do the same thing for aarch64 as the above code for x86-64?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants