-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Arm64 support #4087
base: main
Are you sure you want to change the base?
Windows Arm64 support #4087
Conversation
Hi @Binozo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@Binozo Hi, thank you for making windows arm64 support! Would you mind fix the CI signals? Would be really appreciated it |
Sure! |
@junjieqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
return (int)__lzcnt64(x); | ||
#elif defined(_M_ARM64) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @Binozo This doesn't appear to be Windows specific actually. Does it do the same thing for aarch64 as the above code for x86-64?
Hey there 👋
currently I am working on a project using faiss using FaissMask (.NET Bindings).
As I am developing on a windows arm64 machine I needed a way to compile faiss for windows arm.
I ran the tests in FaissMask and my little hack seemed valid.
Here is a little script to compile it yourself:
(Make sure you compiled
OpenBLAS
for windows arm64 before and adjustC:\Users\<USER>\CLionProjects\OpenBLAS\cmake-build-release\lib\Release\openblas.lib
if needed)