Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchParameters support for IndexBinaryFlat #4055

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

SearchParameters support for IndexBinaryFlat #4055

wants to merge 10 commits into from

Conversation

gustavz
Copy link

@gustavz gustavz commented Dec 4, 2024 •
edited
Loading

Context issue: #3503

We need search params support for binary flat index to be able to use it in RAG applications that support search with pre-filtering.

@facebook-github-bot
Copy link
Contributor

Hi @gustavz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@gustavz gustavz mentioned this pull request Dec 4, 2024
Open
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@gustavz gustavz changed the title Search params support for IndexBinaryFlat SearchParameters support for IndexBinaryFlat Dec 4, 2024
@gustavz
Copy link
Author

gustavz commented Dec 11, 2024

@mnorris11 whats the process of getting this PR reviewed and merged?

@mnorris11
Copy link

@gustavz We triaged it internally (the implementation tag), so someone will review it soon. We have an internal task tracking its review.

asadoughi
asadoughi requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@asadoughi asadoughi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! It looks like the PR is missing the changes to hamming.h for the additional IDSelector argument. Could you add those, please?

faiss/utils/approx_topk_hamming/approx_topk_hamming.h Outdated Show resolved Hide resolved
tests/test_search_params.py Outdated Show resolved Hide resolved
tests/test_search_params.py Show resolved Hide resolved
@gustavz gustavz force-pushed the gustavz/search_params_support_for_index_binary_flat branch from 2717b86 to d70e64b Compare December 12, 2024 08:23
@gustavz gustavz requested a review from asadoughi December 12, 2024 08:23
asadoughi
asadoughi requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@asadoughi asadoughi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few more tweaks

faiss/utils/approx_topk_hamming/approx_topk_hamming.h Outdated Show resolved Hide resolved
tests/test_search_params.py Outdated Show resolved Hide resolved
faiss/utils/hamming.h Show resolved Hide resolved
@gustavz gustavz force-pushed the gustavz/search_params_support_for_index_binary_flat branch from 539dfae to cd8b5d3 Compare December 16, 2024 09:00
@gustavz gustavz requested a review from asadoughi December 16, 2024 09:13
asadoughi
asadoughi reviewed Dec 20, 2024
View reviewed changes
faiss/utils/hamming.cpp Outdated Show resolved Hide resolved
@gustavz gustavz requested a review from asadoughi December 24, 2024 08:07
@mnorris11
Copy link

Hi @gustavz seems like there is a small compilation error, it's asking for faiss::IDSelector instead of IDSelector?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asadoughi asadoughi Awaiting requested review from asadoughi

Assignees
No one assigned
Labels
CLA Signed Implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gustavz @facebook-github-bot @mnorris11 @asadoughi