Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore #3492

Closed
wants to merge 1 commit into from
Closed

Conversation

abhiramvad
Copy link
Contributor

Adding build folder to gitignore, so that they don't show up in the commit tree while building from source

Adding build folder to gitignore, so that they don't show up in the commit tree while building from source
@facebook-github-bot
Copy link
Contributor

Hi @abhiramvad!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@alexanderguzhva
Copy link
Contributor

lgtm, totally makes sense when building for OSS

@abhiramvad
Copy link
Contributor Author

lgtm, totally makes sense when building for OSS

Thanks, I have signed the CLA, but the check is not passing. Can you help me on this please?

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@asadoughi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@asadoughi merged this pull request in ec67ac1.

tarang-jain pushed a commit to tarang-jain/faiss that referenced this pull request Jul 5, 2024
Summary:
Adding build folder to gitignore, so that they don't show up in the commit tree while building from source

Pull Request resolved: facebookresearch#3492

Reviewed By: junjieqi

Differential Revision: D58171359

Pulled By: asadoughi

fbshipit-source-id: b0efed348769328a3bdbcc13098dcb84cadb6c4f
abhinavdangeti pushed a commit to blevesearch/faiss that referenced this pull request Jul 12, 2024
Summary:
Adding build folder to gitignore, so that they don't show up in the commit tree while building from source

Pull Request resolved: facebookresearch#3492

Reviewed By: junjieqi

Differential Revision: D58171359

Pulled By: asadoughi

fbshipit-source-id: b0efed348769328a3bdbcc13098dcb84cadb6c4f
aalekhpatel07 pushed a commit to aalekhpatel07/faiss that referenced this pull request Oct 17, 2024
Summary:
Adding build folder to gitignore, so that they don't show up in the commit tree while building from source

Pull Request resolved: facebookresearch#3492

Reviewed By: junjieqi

Differential Revision: D58171359

Pulled By: asadoughi

fbshipit-source-id: b0efed348769328a3bdbcc13098dcb84cadb6c4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants