-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ST_norm_from_LUT for AdditiveQuantizer search #3882
Labels
Comments
This is more a note for myself to implement it. |
mdouze
added a commit
to mdouze/faiss
that referenced
this issue
Oct 7, 2024
Summary: The norm computation ST_norm_from_LUT was not implemented in Faiss. See issue facebookresearch#3882 This diff adds an implementation for it. It is probably not very quick. A few precomputed tables for AdditiveQuantizer were moved form ResidualQuantizer. Differential Revision: D63975689
facebook-github-bot
pushed a commit
that referenced
this issue
Oct 11, 2024
Summary: Pull Request resolved: #3917 The norm computation ST_norm_from_LUT was not implemented in Faiss. See issue #3882 This diff adds an implementation for it. It is probably not very quick. A few precomputed tables for AdditiveQuantizer were moved form ResidualQuantizer. Reviewed By: asadoughi Differential Revision: D63975689 fbshipit-source-id: 1bbe497a66bb3891ae727a1cd2b719479f80a836
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this issue
Oct 17, 2024
…h#3917) Summary: Pull Request resolved: facebookresearch#3917 The norm computation ST_norm_from_LUT was not implemented in Faiss. See issue facebookresearch#3882 This diff adds an implementation for it. It is probably not very quick. A few precomputed tables for AdditiveQuantizer were moved form ResidualQuantizer. Reviewed By: asadoughi Differential Revision: D63975689 fbshipit-source-id: 1bbe497a66bb3891ae727a1cd2b719479f80a836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The additive quantizers need to carry around the norms of the vectors to compute L2 distances, or they can be computed.
The storage options work but the
ST_norm_from_LUT
is not implemented (it is described in eq (16) of the Faiss paper).the symptom is a crash because the interpreter does not propagate the exception correctly.
result:
The text was updated successfully, but these errors were encountered: