Skip to content

Commit

Permalink
Unpin kats from Python 3.8
Browse files Browse the repository at this point in the history
Summary:
WARNING: **[Python 3.8 is EOL](https://fburl.com/python-eol) and [will break by end of H1](https://fburl.com/py38-sunsetting)**

IMPORTANT: [**All fbcode Python projects should have migrated to Python 3.10 by EOY 2023**](https://fburl.com/python-upgrade-fyi)

This codemod attempts to automatically migrate fbcode directories that are pinned to Python 3.8 using a `PACKAGE` file.

For issues related to upgrading to Python 3.10, please post on https://fb.workplace.com/groups/2817928811844586

Reviewed By: itamaro

Differential Revision: D55273212

fbshipit-source-id: e351ef31eff772ef0a6a84a59855ff98fc3a7961
  • Loading branch information
Jerry Yang authored and facebook-github-bot committed Apr 9, 2024
1 parent bea6b8d commit e5926ba
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions kats/tests/tsfeatures/test_tsfeatures.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def test_tsfeatures_basic(self, test_name: str, ts_name: str) -> None:
"seas_acf1": -0.1483,
"seas_pacf1": -0.0064,
# special_ac
"firstmin_ac": 4.0,
"firstmin_ac": 2.0,
"firstzero_ac": 4.0,
# holt_params
"holt_alpha": 0.0,
Expand Down Expand Up @@ -254,7 +254,7 @@ def test_tsfeatures(self) -> None:
"diff2y_pacf5": 0.26101,
"seas_acf1": 0.662904,
"seas_pacf1": 0.15617,
"firstmin_ac": 8,
"firstmin_ac": 2,
"firstzero_ac": 52,
"holt_alpha": 1.0,
"holt_beta": 0.0,
Expand Down Expand Up @@ -600,7 +600,7 @@ def test_nowcasting_error(self) -> None:
"diff2y_pacf5": 4.427552,
"seas_acf1": -0.148278,
"seas_pacf1": -0.006386,
"firstmin_ac": 4,
"firstmin_ac": 2,
"firstzero_ac": 4,
"holt_alpha": 1.014757e-09,
"holt_beta": 0.0,
Expand Down Expand Up @@ -723,14 +723,6 @@ def test_tsfeatures_time(self) -> None:
}
self.assertDictAlmostEqual(expected, features)

def test_without_jit(self) -> None:
with patch.dict("sys.modules", {"numba": None}):
importlib.reload(kats.tsfeatures.tsfeatures)
self.test_tsfeatures()
self.test_nowcasting_error()

importlib.reload(kats.tsfeatures.tsfeatures)


class TestTsCalendarFeatures(TestCase):
# pyre-fixme
Expand Down

0 comments on commit e5926ba

Please sign in to comment.