Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSD cache code cleanup #9724

Closed
wants to merge 1 commit into from
Closed

SSD cache code cleanup #9724

wants to merge 1 commit into from

Conversation

xiaoxmeng
Copy link
Contributor

No description provided.

@xiaoxmeng xiaoxmeng marked this pull request as ready for review May 6, 2024 19:22
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2024
@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit bc76227
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6639a8327e2e430009c4cb4d

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xiaoxmeng xiaoxmeng force-pushed the cleanup branch 2 times, most recently from 6e29123 to 8c932be Compare May 6, 2024 20:28
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xiaoxmeng xiaoxmeng force-pushed the cleanup branch 2 times, most recently from 8e43393 to f17d351 Compare May 6, 2024 23:02
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

zacw7
zacw7 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@zacw7 zacw7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cleanup.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request May 7, 2024
@xiaoxmeng @facebook-github-bot
SSD cache code cleanup (facebookincubator#9724)
e8e53b0 
Summary: Pull Request resolved: facebookincubator#9724

Reviewed By: zacw7

Differential Revision: D57012132

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57012132

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request May 7, 2024
@xiaoxmeng @facebook-github-bot
SSD cache code cleanup (facebookincubator#9724)
36fc7b4 
Summary: Pull Request resolved: facebookincubator#9724

Reviewed By: zacw7

Differential Revision: D57012132

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57012132

@xiaoxmeng @facebook-github-bot
SSD cache code cleanup (facebookincubator#9724)
bc76227 
Summary: Pull Request resolved: facebookincubator#9724

Reviewed By: zacw7

Differential Revision: D57012132

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57012132

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 668d578.

@xiaoxmeng xiaoxmeng deleted the cleanup branch May 7, 2024 06:51
@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 668d5784.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request May 8, 2024
@xiaoxmeng @Joe-Abraham
SSD cache code cleanup (facebookincubator#9724)
b8a9152 
Summary: Pull Request resolved: facebookincubator#9724

Reviewed By: zacw7

Differential Revision: D57012132

Pulled By: xiaoxmeng

fbshipit-source-id: 390ec69d19206a7dac4aabc915db4b3b140076f4
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Jun 7, 2024
@xiaoxmeng @Joe-Abraham
SSD cache code cleanup (facebookincubator#9724)
0fcc7b4 
Summary: Pull Request resolved: facebookincubator#9724

Reviewed By: zacw7

Differential Revision: D57012132

Pulled By: xiaoxmeng

fbshipit-source-id: 390ec69d19206a7dac4aabc915db4b3b140076f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacw7 zacw7 zacw7 approved these changes

@gggrace14 gggrace14 Awaiting requested review from gggrace14

@mbasmanova mbasmanova Awaiting requested review from mbasmanova

@oerling oerling Awaiting requested review from oerling

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxmeng @facebook-github-bot @zacw7