Consolidate SpillStats #9211
Closed
Consolidate SpillStats #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
6ba9973 to
7a997a9
Compare
xiaoxmeng
reviewed
Mar 22, 2024
xiaoxmeng
reviewed
Mar 23, 2024
3010211 to
e8e004b
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 8f0adb1. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
wypb
pushed a commit
to wypb/velox
that referenced
this pull request
Mar 25, 2024
Summary: Decouple spill stats from the spiller as row number and hash probe spilling might use more than one and different spillers. Consolidate to use one spill stats to collect the spill stats to streamline implementation. This PR introduces a synchronized spill stats within the operator to gather these stats and later on we could separate them for different types of spiller if offline analysis needs. Pull Request resolved: facebookincubator#9211 Reviewed By: tanjialiang Differential Revision: D55287100 Pulled By: xiaoxmeng fbshipit-source-id: ffde57d4f3425e3f3f679252504f7690e8dfce68
wypb
pushed a commit
to wypb/velox
that referenced
this pull request
Mar 25, 2024
Summary: Decouple spill stats from the spiller as row number and hash probe spilling might use more than one and different spillers. Consolidate to use one spill stats to collect the spill stats to streamline implementation. This PR introduces a synchronized spill stats within the operator to gather these stats and later on we could separate them for different types of spiller if offline analysis needs. Pull Request resolved: facebookincubator#9211 Reviewed By: tanjialiang Differential Revision: D55287100 Pulled By: xiaoxmeng fbshipit-source-id: ffde57d4f3425e3f3f679252504f7690e8dfce68
wypb
pushed a commit
to wypb/velox
that referenced
this pull request
Mar 25, 2024
Summary: Decouple spill stats from the spiller as row number and hash probe spilling might use more than one and different spillers. Consolidate to use one spill stats to collect the spill stats to streamline implementation. This PR introduces a synchronized spill stats within the operator to gather these stats and later on we could separate them for different types of spiller if offline analysis needs. Pull Request resolved: facebookincubator#9211 Reviewed By: tanjialiang Differential Revision: D55287100 Pulled By: xiaoxmeng fbshipit-source-id: ffde57d4f3425e3f3f679252504f7690e8dfce68
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Decouple spill stats from the spiller as row number and hash probe spilling might use more than one and different spillers. Consolidate to use one spill stats to collect the spill stats to streamline implementation. This PR introduces a synchronized spill stats within the operator to gather these stats and later on we could separate them for different types of spiller if offline analysis needs. Pull Request resolved: facebookincubator#9211 Reviewed By: tanjialiang Differential Revision: D55287100 Pulled By: xiaoxmeng fbshipit-source-id: ffde57d4f3425e3f3f679252504f7690e8dfce68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple spill stats from the spiller as row number and hash probe spilling might
use more than one and different spillers. Consolidate to use one spill stats to collect
the spill stats to streamline implementation. This PR introduces a synchronized spill
stats within the operator to gather these stats and later on we could separate them
for different types of spiller if offline analysis needs.