Return remaining bytes from exchange sources #8758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D53793123 |
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Feb 15, 2024
Summary: This is the first diff to upgrade the exchange protocol. This change only exposes the remaining bytes to buffer manager; it does not change the existing protocol yet, and is compatible with the current Prestissimo code. Also added a few statistics to spot skewed exchange. See prestodb/presto#21926 for details about the design. Differential Revision: D53793123
231f9fd to
4480722
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53793123 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Feb 15, 2024
Summary: This is the first diff to upgrade the exchange protocol. This change only exposes the remaining bytes to buffer manager; it does not change the existing protocol yet, and is compatible with the current Prestissimo code. Also added a few statistics to spot skewed exchange. See prestodb/presto#21926 for details about the design. Differential Revision: D53793123
4480722 to
200a8b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53793123 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Feb 15, 2024
Summary: This is the first diff to upgrade the exchange protocol. This change only exposes the remaining bytes to buffer manager; it does not change the existing protocol yet, and is compatible with the current Prestissimo code. Also added a few statistics to spot skewed exchange. See prestodb/presto#21926 for details about the design. Differential Revision: D53793123
200a8b2 to
dd0ab35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53793123 |
mbasmanova
approved these changes
Feb 15, 2024
| @@ -78,6 +81,9 @@ class ArbitraryBuffer { | |||
| /// there are sufficient buffered pages. | |||
| std::vector<std::shared_ptr<SerializedPage>> getPages(uint64_t maxBytes); | |||
|
|
|||
| /// Append the available page sizes to `out'. | |||
| void getAvailablePageSizes(std::vector<int64_t>& out) const; | |||
There was a problem hiding this comment.
Any particular reason not to return std::vector?
There was a problem hiding this comment.
So we don't need to create a new vector every time and just appending the existing one already created for DestinationBuffer
Summary: This is the first diff to upgrade the exchange protocol. This change only exposes the remaining bytes to buffer manager; it does not change the existing protocol yet, and is compatible with the current Prestissimo code. See prestodb/presto#21926 for details about the design. Reviewed By: mbasmanova Differential Revision: D53793123
dd0ab35 to
00f46e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53793123 |
|
This pull request has been merged in 9c79ef9. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is the first diff to upgrade the exchange protocol. This change
only exposes the remaining bytes to buffer manager; it does not change the
existing protocol yet, and is compatible with the current Prestissimo code.
Also added a few statistics to spot skewed exchange.
See prestodb/presto#21926 for details about the
design.
Differential Revision: D53793123