Extend PrestoSerializer::deserialize to allow appending to existing vector #7447
Conversation
✅ Deploy Preview for meta-velox canceled.
|
5fb8d0b to
2242d56
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -970,6 +1133,7 @@ class VectorStream { | |||
| } | |||
| [[fallthrough]]; | |||
| case TypeKind::ARRAY: | |||
| [[fallthrough]]; | |||
There was a problem hiding this comment.
Shall we use FOLLY_FALLTHROUGH? Thanks!
| nulls->asMutable<uint64_t>(), 0, resultOffset, bits::kNotNull); | ||
| } | ||
|
|
||
| auto rawNulls = nulls->asMutable<uint8_t>() + bits::nbytes(resultOffset); |
| scatterBits(scatterSize, scatter, values); | ||
|
|
||
| for (auto index = scatterSize - 1; index >= 0; --index) { | ||
| auto destination = scatter[index]; |
There was a problem hiding this comment.
nit: const auto destination =
2242d56 to
9edec57
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
9edec57 to
b3d40c0
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
b3d40c0 to
4efd5d7
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 4659a3d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
The new capability will allow for efficient merging of small batched in Exchange operator.