Fix Array/Map/RowVector::copyRanges for UNKNOWN source #6607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
becf0b5 to
a50f8b5
Compare
a50f8b5 to
415ad04
Compare
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
duanmeng
reviewed
Sep 16, 2023
| if (leafVector->isConstantEncoding()) { | ||
| // A null constant does not have a value vector, so wrappedVector | ||
| // returns the constant. | ||
| VELOX_CHECK(leafVector->isNullAt(0)); |
There was a problem hiding this comment.
I believe this is not a user error, but rather a bug inside Velox as it should not allow creating vectors that would trigger this check.
xiaoxmeng
approved these changes
Sep 16, 2023
|
@mbasmanova merged this pull request in 63fa93a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6607) Summary: Fix crashes when copying from TypeKind::UNKNOWN vector in the following methods: - Map/Array/RowVector::copyRanges - FlatVector<StringView>::copyRanges - FlatVector<bool>::copy(source, rows, toSourceRow) - RowVector::copy(source, rows, toSourceRow) Fixes facebookincubator#6606 Pull Request resolved: facebookincubator#6607 Reviewed By: xiaoxmeng Differential Revision: D49348224 Pulled By: mbasmanova fbshipit-source-id: 57598428a36787ee3c57a1b7c9f6cffd11206bf6
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6607) Summary: Fix crashes when copying from TypeKind::UNKNOWN vector in the following methods: - Map/Array/RowVector::copyRanges - FlatVector<StringView>::copyRanges - FlatVector<bool>::copy(source, rows, toSourceRow) - RowVector::copy(source, rows, toSourceRow) Fixes facebookincubator#6606 Pull Request resolved: facebookincubator#6607 Reviewed By: xiaoxmeng Differential Revision: D49348224 Pulled By: mbasmanova fbshipit-source-id: 57598428a36787ee3c57a1b7c9f6cffd11206bf6
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
…ator#6607) Summary: Fix crashes when copying from TypeKind::UNKNOWN vector in the following methods: - Map/Array/RowVector::copyRanges - FlatVector<StringView>::copyRanges - FlatVector<bool>::copy(source, rows, toSourceRow) - RowVector::copy(source, rows, toSourceRow) Fixes facebookincubator#6606 Pull Request resolved: facebookincubator#6607 Reviewed By: xiaoxmeng Differential Revision: D49348224 Pulled By: mbasmanova fbshipit-source-id: 57598428a36787ee3c57a1b7c9f6cffd11206bf6
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
…ator#6607) Summary: Fix crashes when copying from TypeKind::UNKNOWN vector in the following methods: - Map/Array/RowVector::copyRanges - FlatVector<StringView>::copyRanges - FlatVector<bool>::copy(source, rows, toSourceRow) - RowVector::copy(source, rows, toSourceRow) Fixes facebookincubator#6606 Pull Request resolved: facebookincubator#6607 Reviewed By: xiaoxmeng Differential Revision: D49348224 Pulled By: mbasmanova fbshipit-source-id: 57598428a36787ee3c57a1b7c9f6cffd11206bf6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crashes when copying from TypeKind::UNKNOWN vector in the following methods:
Fixes #6606