Adding Code of Conduct file #5

facebook-github-bot · 2021-08-09T10:33:20Z

This is pull request was created automatically because we noticed your project was missing a Code of Conduct file.

Code of Conduct files facilitate respectful and constructive communities by establishing expected behaviors for project contributors.

This PR was crafted with love by Facebook's Open Source Team.

mbasmanova · 2021-09-16T07:16:44Z

Done by @pedroerp

…ator#5) * Fix dependency issue * Correct code style

* Address comments from PR facebookincubator#5 * Refactor to pass down IR to Operator level

…ator#5) * Fix dependency issue * Correct code style

* Address comments from PR facebookincubator#5 * Refactor to pass down IR to Operator level

Summary: Enhance printExprWithStats to identify common-sub expressions. For example, `c0 + c1` is a common sub-expression in `"(c0 + c1) % 5", " (c0 + c1) % 3"` expression set. It is evaluated only once and there is a single Expr object that represents it. That object appears in the expression tree twice. printExprWithStats does not show the runtime stats for second instance of that expression and instead annotates it with `[CSE https://github.com/facebookincubator/velox/issues/2]`, where CSE stands for common sub-expression and 2 refers to the first instance of the expression. ``` mod [cpu time: 50.49us, rows: 1024] -> BIGINT [#1] cast(plus as BIGINT) [cpu time: 68.15us, rows: 1024] -> BIGINT [#2] plus [cpu time: 51.84us, rows: 1024] -> INTEGER [#3] c0 [cpu time: 0ns, rows: 0] -> INTEGER [#4] c1 [cpu time: 0ns, rows: 0] -> INTEGER [#5] 5:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [#6] mod [cpu time: 49.29us, rows: 1024] -> BIGINT [#7] cast((plus(c0, c1)) as BIGINT) -> BIGINT [CSE #2] 3:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [#8] ``` Pull Request resolved: #1500 Reviewed By: Yuhta Differential Revision: D35994836 Pulled By: mbasmanova fbshipit-source-id: 6bacbbe61b68dad97ce2fd5f99610c4ad55897be

…tor#1500) Summary: Enhance printExprWithStats to identify common-sub expressions. For example, `c0 + c1` is a common sub-expression in `"(c0 + c1) % 5", " (c0 + c1) % 3"` expression set. It is evaluated only once and there is a single Expr object that represents it. That object appears in the expression tree twice. printExprWithStats does not show the runtime stats for second instance of that expression and instead annotates it with `[CSE https://github.com/facebookincubator/velox/issues/2]`, where CSE stands for common sub-expression and 2 refers to the first instance of the expression. ``` mod [cpu time: 50.49us, rows: 1024] -> BIGINT [#1] cast(plus as BIGINT) [cpu time: 68.15us, rows: 1024] -> BIGINT [facebookincubator#2] plus [cpu time: 51.84us, rows: 1024] -> INTEGER [facebookincubator#3] c0 [cpu time: 0ns, rows: 0] -> INTEGER [facebookincubator#4] c1 [cpu time: 0ns, rows: 0] -> INTEGER [facebookincubator#5] 5:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [facebookincubator#6] mod [cpu time: 49.29us, rows: 1024] -> BIGINT [facebookincubator#7] cast((plus(c0, c1)) as BIGINT) -> BIGINT [CSE facebookincubator#2] 3:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [facebookincubator#8] ``` Pull Request resolved: facebookincubator#1500 Reviewed By: Yuhta Differential Revision: D35994836 Pulled By: mbasmanova fbshipit-source-id: 6bacbbe61b68dad97ce2fd5f99610c4ad55897be

…tor#1500) Summary: Enhance printExprWithStats to identify common-sub expressions. For example, `c0 + c1` is a common sub-expression in `"(c0 + c1) % 5", " (c0 + c1) % 3"` expression set. It is evaluated only once and there is a single Expr object that represents it. That object appears in the expression tree twice. printExprWithStats does not show the runtime stats for second instance of that expression and instead annotates it with `[CSE https://github.com/facebookincubator/velox/issues/2]`, where CSE stands for common sub-expression and 2 refers to the first instance of the expression. ``` mod [cpu time: 50.49us, rows: 1024] -> BIGINT [facebookincubator#1] cast(plus as BIGINT) [cpu time: 68.15us, rows: 1024] -> BIGINT [facebookincubator#2] plus [cpu time: 51.84us, rows: 1024] -> INTEGER [facebookincubator#3] c0 [cpu time: 0ns, rows: 0] -> INTEGER [facebookincubator#4] c1 [cpu time: 0ns, rows: 0] -> INTEGER [facebookincubator#5] 5:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [facebookincubator#6] mod [cpu time: 49.29us, rows: 1024] -> BIGINT [facebookincubator#7] cast((plus(c0, c1)) as BIGINT) -> BIGINT [CSE facebookincubator#2] 3:BIGINT [cpu time: 0ns, rows: 0] -> BIGINT [facebookincubator#8] ``` Pull Request resolved: facebookincubator#1500 Reviewed By: Yuhta Differential Revision: D35994836 Pulled By: mbasmanova fbshipit-source-id: 6bacbbe61b68dad97ce2fd5f99610c4ad55897be

Add -fPIC and rm OBJECT (facebookincubator#5)

…range Fix decimal filter range parse

Summary: The default algorithm used is MD5. However, MD5 is not supported with fips and can cause a SIGSEGV. Set CRC32 instead which is a standard for checksum computation and is not restricted by fips. crc32 is also faster than md5. Internally at IBM, we hit the following SIGSEGV ``` 0x0000000000000000 in ?? () Missing separate debuginfos, use: dnf debuginfo-install openssl-fips-provider-3.0.7-2.el9.x86_64 xz-libs-5.2.5-8.el9_0.x86_64 (gdb) bt #0 0x0000000000000000 in ?? () #1 0x0000000004e5f89b in Aws::Utils::Crypto::MD5OpenSSLImpl::Calculate(std::istream&) () #2 0x0000000004efd298 in Aws::Utils::Crypto::MD5::Calculate(std::istream&) () #3 0x0000000004ef71b9 in Aws::Utils::HashingUtils::CalculateMD5(std::iostream&) () #4 0x0000000004e8ebe8 in Aws::Client::AWSClient::AddChecksumToRequest(std::shared_ptr<Aws::Http::HttpRequest> const&, Aws::AmazonWebServiceRequest const&) const () #5 0x0000000004e8ed15 in Aws::Client::AWSClient::BuildHttpRequest(Aws::AmazonWebServiceRequest const&, std::shared_ptr<Aws::Http::HttpRequest> const&) const () #6 0x0000000004e977f9 in Aws::Client::AWSClient::AttemptOneRequest(std::shared_ptr<Aws::Http::HttpRequest> const&, Aws::AmazonWebServiceRequest const&, char const*, char const*, char const*) const () #7 0x0000000004e9e1c0 in Aws::Client::AWSClient::AttemptExhaustively(Aws::Http::URI const&, Aws::AmazonWebServiceRequest const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const () #8 0x0000000004ea15e8 in Aws::Client::AWSXMLClient::MakeRequest(Aws::Http::URI const&, Aws::AmazonWebServiceRequest const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const () #9 0x0000000004ea1f70 in Aws::Client::AWSXMLClient::MakeRequest(Aws::AmazonWebServiceRequest const&, Aws::Endpoint::AWSEndpoint const&, Aws::Http::HttpMethod, char const*, char const*, char const*) const () #10 0x0000000004de0933 in Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const::{lambda()https://github.com/facebookincubator/velox/issues/1}::operator()() const () #11 0x0000000004de0b8c in std::_Function_handler<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> (), Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const::{lambda()https://github.com/facebookincubator/velox/issues/1}>::_M_invoke(std::_Any_data const&) () #12 0x0000000004e19317 in Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> smithy::components::tracing::TracingUtils::MakeCallWithTiming<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> >(std::function<Aws::Utils::Outcome<Aws::S3::Model::UploadPartResult, Aws::S3::S3Error> ()>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, smithy::components::tracing::Meter const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () #13 0x0000000004d7cdcf in Aws::S3::S3Client::UploadPart(Aws::S3::Model::UploadPartRequest const&) const () #14 0x0000000004ca4aa6 in facebook::velox::filesystems::S3WriteFile::Impl::uploadPart (this=0x7fffec2f09a0, part=..., isLast=true) at /root/velox/velox/connectors/hive/storage_adapters/s3fs/S3FileSystem.cpp:380 ``` Pull Request resolved: #10801 Reviewed By: amitkdutta Differential Revision: D61671574 Pulled By: kgpai fbshipit-source-id: 34c7b777b3fde0659ef74c4fbfd93740fdfa3f7c

Enable CI runs for cudf-velox pull requests

OSS Automated Fix: Addition of Code of Conduct

96788bc

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 9, 2021

mbasmanova mentioned this pull request Aug 17, 2021

Support for ascii encoding for a subset of rows. #32

Closed

pedroerp mentioned this pull request Aug 18, 2021

fromUnixtime() crashes if it gets a NaN or Inf #67

Closed

mbasmanova closed this Sep 16, 2021

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Fix dependency issue for ordered map and json in Velox (facebookincub…

1acfb5d

…ator#5) * Fix dependency issue * Correct code style

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Address comments from PR facebookincubator#5 (facebookincubator#6)

c8d6c12

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Refactor to pass down IR to Operator level (facebookincubator#8)

62e6652

* Address comments from PR facebookincubator#5 * Refactor to pass down IR to Operator level

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Fix dependency issue for ordered map and json in Velox (facebookincub…

5573c5e

…ator#5) * Fix dependency issue * Correct code style

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Address comments from PR facebookincubator#5 (facebookincubator#6)

90a4bca

winningsix pushed a commit to winningsix/velox-1 that referenced this pull request Sep 27, 2021

Refactor to pass down IR to Operator level (facebookincubator#8)

da48a69

* Address comments from PR facebookincubator#5 * Refactor to pass down IR to Operator level

pedroerp mentioned this pull request Nov 8, 2021

More date functionality #552

Closed

rui-mo added a commit to rui-mo/velox that referenced this pull request May 6, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

914b691

rui-mo added a commit to rui-mo/velox that referenced this pull request Jun 24, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

31cf87c

rui-mo added a commit to rui-mo/velox that referenced this pull request Jun 30, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

a0e12b6

rui-mo added a commit to rui-mo/velox that referenced this pull request Jul 20, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

bedae2f

rui-mo added a commit to rui-mo/velox that referenced this pull request Aug 2, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

02f5dcf

rui-mo added a commit to rui-mo/velox that referenced this pull request Aug 12, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

872cc07

rui-mo added a commit to rui-mo/velox that referenced this pull request Aug 22, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

68b0a1b

rui-mo added a commit to rui-mo/velox that referenced this pull request Sep 7, 2022

Add -fPIC and rm OBJECT (facebookincubator#5)

9a57ddd

rui-mo added a commit to rui-mo/velox that referenced this pull request Sep 26, 2022

Expose the registrations for avg and count (facebookincubator#4)

5385bfa

Add -fPIC and rm OBJECT (facebookincubator#5)

This was referenced Oct 8, 2022

from_unixtime() crashes with error: nan is outside the range of representable values of type 'long' #2791

Closed

Substrait velox_plan_conversion_test is flaky #2816

Closed

ebeworld mentioned this pull request Jan 30, 2023

Parallel hash build does not handle partition overflows #3874

Open

liujiayi771 added a commit to liujiayi771/velox that referenced this pull request Mar 13, 2023

support sparksql decimal avg (facebookincubator#5)

f209863

liujiayi771 added a commit to liujiayi771/velox that referenced this pull request Mar 16, 2023

support sparksql decimal avg (facebookincubator#5)

483c50b

rui-mo pushed a commit to rui-mo/velox that referenced this pull request Mar 17, 2023

fix final avg decimal output type (facebookincubator#5)

fa12123

liujiayi771 added a commit to liujiayi771/velox that referenced this pull request Mar 18, 2023

support sparksql decimal avg (facebookincubator#5)

413747f

paul-amonson mentioned this pull request Apr 3, 2023

[Perf] Replaced the S3 connector implementation to use the AWS transfer manager #4272

Closed

billyean mentioned this pull request Jun 7, 2023

Fix velox_aggregates_test memory leaks #5168

Closed

mayunlei mentioned this pull request Jun 7, 2023

Coredump caused by modifying the same vector in multiple Driver threads #5169

Open

liujiayi771 pushed a commit to liujiayi771/velox that referenced this pull request Jun 12, 2023

Merge pull request facebookincubator#5 from liujiayi771/jiayi_filter_…

a07f9ee

…range Fix decimal filter range parse

xiaodai1002 mentioned this pull request Feb 4, 2024

Crash when SimdComparison calls SIMD instructions #8668

Closed

bdice added a commit to bdice/velox that referenced this pull request Dec 19, 2024

Merge pull request facebookincubator#5 from robertmaynard/enable_ci

e6bab5d

Enable CI runs for cudf-velox pull requests

yukkit pushed a commit to yukkit/velox that referenced this pull request Dec 26, 2024

fix ambiguous format_to (facebookincubator#5)

1b9868d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Code of Conduct file #5

Adding Code of Conduct file #5

facebook-github-bot commented Aug 9, 2021

mbasmanova commented Sep 16, 2021

Adding Code of Conduct file #5

Adding Code of Conduct file #5

Conversation

facebook-github-bot commented Aug 9, 2021

mbasmanova commented Sep 16, 2021