Separate dwrf config definition from impl #3393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D41658954 |
xiaoxmeng
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
@HuamengJiang LGTM. Consider add a simple mock test for ConfigBase. Thanks!
velox/common/config/Config.h
Outdated
| template <typename T> | ||
| ConfigBase& unset(const Entry<T>& entry) { | ||
| auto iter = configs_.find(entry.key_); | ||
| if (iter != configs_.end()) { |
There was a problem hiding this comment.
nit: you could just erase directly?
HuamengJiang
pushed a commit
to HuamengJiang/velox-1
that referenced
this pull request
Dec 1, 2022
Summary: Pull Request resolved: facebookincubator#3393 Separate the config definition from the actual mechanism. Rename the impl class as `ConfigBase` and concrete config classes will derive `ConfigBase<ConcreteConfig>` like `dwrf::Config` and just define all the entries. Reviewed By: xiaoxmeng Differential Revision: D41658954 fbshipit-source-id: 3a5f8770fc42b3725228a870ef0146608b544c00
2a4b834 to
efc22fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41658954 |
Summary: Pull Request resolved: facebookincubator#3393 Separate the config definition from the actual mechanism. Rename the impl class as `ConfigBase` and concrete config classes will derive `ConfigBase<ConcreteConfig>` like `dwrf::Config` and just define all the entries. Reviewed By: xiaoxmeng Differential Revision: D41658954 fbshipit-source-id: 989600a32349fc07a316b3ab8d5eacc76984881d
efc22fb to
c046065
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41658954 |
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D41658954