Provide PlanBuilder convenience function #1578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D36303299 |
velox/exec/tests/utils/PlanBuilder.h
Outdated
| /// @param columnNames The columns to be returned from that table. | ||
| PlanBuilder& tableScan( | ||
| const std::shared_ptr<connector::tpch::TpchTableHandle>& tpchTableHandle, | ||
| std::vector<std::string>&& columnNames); |
There was a problem hiding this comment.
Should the "columnNames" parameter be const && ?
There was a problem hiding this comment.
You mean const &? The intent here is to move it in to this this function since the ROW() function expects an rvalue ref (so we can avoid useless copies)
| @@ -321,6 +321,10 @@ RowTypePtr getTableSchema(Table table) { | |||
| return nullptr; // make gcc happy. | |||
| } | |||
|
|
|||
| TypePtr resolveTpchColumn(Table table, const std::string& columnName) { | |||
There was a problem hiding this comment.
Is there a reason for not making "table" parameter const ?
There was a problem hiding this comment.
Table is a enum (a single byte), so const ref is more expensive than passing by value.
There was a problem hiding this comment.
Sounds reasonable. Thanks.
Summary: Pull Request resolved: facebookincubator#1578 Add a PlanBuilder.tableScane helper function to reduce the amount of boilerplace when pulling data out of TPC-H connector. Reviewed By: kagamiori Differential Revision: D36303299 fbshipit-source-id: 854e1477092fca8b342b1c9971abfb7eeeb8a578
80a4e00 to
84434e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D36303299 |
Arty-Maly
pushed a commit
to Arty-Maly/velox
that referenced
this pull request
May 13, 2022
Summary: Pull Request resolved: facebookincubator#1578 Add a PlanBuilder.tableScane helper function to reduce the amount of boilerplace when pulling data out of TPC-H connector. Reviewed By: kagamiori Differential Revision: D36303299 fbshipit-source-id: d5898559a94c97850a38711a90202caf24e8fca6
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 21, 2022
Summary: Pull Request resolved: facebookincubator#1578 Add a PlanBuilder.tableScane helper function to reduce the amount of boilerplace when pulling data out of TPC-H connector. Reviewed By: kagamiori Differential Revision: D36303299 fbshipit-source-id: d5898559a94c97850a38711a90202caf24e8fca6
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
Summary: Pull Request resolved: facebookincubator#1578 Add a PlanBuilder.tableScane helper function to reduce the amount of boilerplace when pulling data out of TPC-H connector. Reviewed By: kagamiori Differential Revision: D36303299 fbshipit-source-id: d5898559a94c97850a38711a90202caf24e8fca6
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
…en get attribute name (facebookincubator#1578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a PlanBuilder.tableScane helper function to reduce the amount of
boilerplace when pulling data out of TPC-H connector.
Differential Revision: D36303299