Change functions in Velox directory to use the new writer interface. #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is part of the step1 deprecating old writers. A following diff will replace ArrayWriterT and switch out_type<Array> meaning, the same for all other types. Differential Revision: D35625851 fbshipit-source-id: 4c15b07b38ec96371aec1ae02bce632e1a9315e7
|
This pull request was exported from Phabricator. Differential Revision: D35625851 |
Arty-Maly
pushed a commit
to Arty-Maly/velox
that referenced
this pull request
May 13, 2022
…acebookincubator#1415) Summary: Pull Request resolved: facebookincubator#1415 This part is step one towards deprecating old writers. The following diff will replace ArrayWriterT and switch out_type<Array> meaning, the same for all other types. Reviewed By: mbasmanova Differential Revision: D35625851 fbshipit-source-id: 29b01bdbce75fa0f694d17495240981ad380b9c7
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
…acebookincubator#1415) Summary: Pull Request resolved: facebookincubator#1415 This part is step one towards deprecating old writers. The following diff will replace ArrayWriterT and switch out_type<Array> meaning, the same for all other types. Reviewed By: mbasmanova Differential Revision: D35625851 fbshipit-source-id: 29b01bdbce75fa0f694d17495240981ad380b9c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is part is step one towards deprecating old writers.
A following diff will replace ArrayWriterT and switch out_type meaning, the same for all other types.
Differential Revision: D35625851