Use ContinuePromise #1410
Closed
Use ContinuePromise #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
majetideepak
approved these changes
Apr 13, 2022
Summary: Use ContinuePromise instead of VeloxPromise<bool> throughout the code base for consistency (with ContinueFuture) and readability. Pull Request resolved: facebookincubator#1410 Reviewed By: kagamiori Differential Revision: D35617219 Pulled By: mbasmanova fbshipit-source-id: 755951f4dc57204581baa67294bc5107df8e9219
|
This pull request was exported from Phabricator. Differential Revision: D35617219 |
cf866b7 to
9882884
Compare
Arty-Maly
pushed a commit
to Arty-Maly/velox
that referenced
this pull request
May 13, 2022
Summary: Use ContinuePromise instead of VeloxPromise<bool> throughout the code base for consistency (with ContinueFuture) and readability. Pull Request resolved: facebookincubator#1410 Reviewed By: kagamiori Differential Revision: D35617219 Pulled By: mbasmanova fbshipit-source-id: 5bce0aad8f7bb9f97d94bc688751c5594aa23783
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
Summary: Use ContinuePromise instead of VeloxPromise<bool> throughout the code base for consistency (with ContinueFuture) and readability. Pull Request resolved: facebookincubator#1410 Reviewed By: kagamiori Differential Revision: D35617219 Pulled By: mbasmanova fbshipit-source-id: 5bce0aad8f7bb9f97d94bc688751c5594aa23783
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
…bator#1411) What changes were proposed in this pull request? This pr converts partition names get from hdfs path to lower case, as spark paritiions are in lower case. (Fixes: facebookincubator#1410) How was this patch tested? This patch was tested manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ContinuePromise instead of VeloxPromise throughout the code base for
consistency (with ContinueFuture) and readability.