misc: Update python versions used for pyvelox #12157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
assignUser
reviewed
Jan 24, 2025
The current minimum is python 3.7. but that has passed EOL. This change sets the minimum at the oldest supported version 3.9.
481c35b to
ec18a87
Compare
Ensure fuzzer jobs run when the setup.py is updated.
|
@assignUser I made another commit to run the fuzzer jobs on setup.py change. |
|
@assignUser Please review. You think this is ok with the two commits? |
assignUser
approved these changes
Jan 29, 2025
|
@bikramSingh91 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@bikramSingh91 merged this pull request in 256ed01. |
ArnavBalyan
pushed a commit
to ArnavBalyan/velox
that referenced
this pull request
Jan 31, 2025
Summary: The current minimum is python 3.7. but that has passed EOL. This change sets the minimum at the oldest supported version 3.9. Pull Request resolved: facebookincubator#12157 Reviewed By: kgpai Differential Revision: D68863807 Pulled By: bikramSingh91 fbshipit-source-id: 46cc43b4b418b3eb8c3681cd7548e5f4a3f68f13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current minimum is python 3.7. but that has passed EOL. This change sets the minimum at the oldest supported version 3.9.