Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Disable O_DIRECT in cache fuzzer #12154

Closed
wants to merge 1 commit into from
Closed

test: Disable O_DIRECT in cache fuzzer #12154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions velox/common/file/tests/FaultyFileSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ class FaultyFileSystem : public FileSystem {
// Extracts the delegated real file path by removing the faulty file system
// scheme prefix.
inline std::string_view extractPath(std::string_view path) const override {
VELOX_CHECK_EQ(path.find(scheme()), 0, "");
const auto filePath = path.substr(scheme().length());
const auto filePath =
(path.find(scheme()) == 0) ? path.substr(scheme().length()) : path;
return getFileSystem(filePath, config_)->extractPath(filePath);
}

Expand Down
7 changes: 6 additions & 1 deletion velox/exec/fuzzer/CacheFuzzer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
#include "velox/common/memory/MmapAllocator.h"
#include "velox/dwio/common/CachedBufferedInput.h"
#include "velox/exec/tests/utils/TempDirectoryPath.h"
#include "velox/vector/fuzzer/Utils.h"

DEFINE_int32(steps, 10, "Number of plans to generate and test.");

Expand Down Expand Up @@ -498,6 +497,12 @@ void CacheFuzzer::go() {
FLAGS_steps > 0 || FLAGS_duration_sec > 0,
"Either --steps or --duration_sec needs to be greater than zero.");

// O_DIRECT requires I/O size to be the same as a disk file block size which
// is not handled in SSD cache. Misalignment can lead to EINVAL in some
// filesystem and kernel version.
//
// TODO: add this support if needed later.
FLAGS_ssd_odirect = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a "// TODO: add this support if needed later."?

auto startTime = std::chrono::system_clock::now();
size_t iteration = 0;

Expand Down
Loading