misc: Add support for row_constructor and dereference expressions in ToSqlUtil #11883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67310284 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Dec 17, 2024
…ToSqlUtil (facebookincubator#11883) Summary: Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were never used. This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers comparing agains Presto. Differential Revision: D67310284
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Dec 17, 2024
…ToSqlUtil (facebookincubator#11883) Summary: Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were never used. This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers comparing agains Presto. Differential Revision: D67310284
kagamiori
approved these changes
Jan 3, 2025
…ToSqlUtil (facebookincubator#11883) Summary: Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were never used. This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers comparing agains Presto. Reviewed By: kagamiori Differential Revision: D67310284
7ae450a to
4d88f54
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67310284 |
|
This pull request has been merged in 9da5fa7. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ToSqlUtil (facebookincubator#11883) Summary: Pull Request resolved: facebookincubator#11883 Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were never used. This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers comparing agains Presto. Reviewed By: kagamiori Differential Revision: D67310284 fbshipit-source-id: 4bf882b1cf358afa78005758fd3b0677ef7415e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support for row_constructor and dereference expressions were never added to ToSqlUtil. This file is used by
Fuzzer QueryRunners (particularly Presto) to generate SQL to execute. I'm guessing these features were
never used.
This is needed as part of enabling support for custom types not supported in DWRF files in Fuzzers
comparing agains Presto.
Differential Revision: D67310284