refactor: Clean up, match presto, and optimize ipprefix string -> ipprefix #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
czentgr
reviewed
Dec 2, 2024
yuandagits
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
look good, thanks!
@czentgr has good suggestion re. the simplification
1110af3 to
ae12950
Compare
Yuhta
approved these changes
Dec 2, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in c542ebc. |
TongWei1105
pushed a commit
to TongWei1105/velox
that referenced
this pull request
Dec 3, 2024
…refix (facebookincubator#11670) Summary: Clean up the code for converting from string->ipprefix. Also removed all unnecessary error message processing to match java presto's output. Removed unnecessary variables Enable IPPREFIX cast test Pull Request resolved: facebookincubator#11670 Reviewed By: yuandagits Differential Revision: D66682847 Pulled By: xiaoxmeng fbshipit-source-id: b31ff7c563a9e7e3c14ec42ef80537e64773fc8f
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…refix (facebookincubator#11670) Summary: Clean up the code for converting from string->ipprefix. Also removed all unnecessary error message processing to match java presto's output. Removed unnecessary variables Enable IPPREFIX cast test Pull Request resolved: facebookincubator#11670 Reviewed By: yuandagits Differential Revision: D66682847 Pulled By: xiaoxmeng fbshipit-source-id: b31ff7c563a9e7e3c14ec42ef80537e64773fc8f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the code for converting from string->ipprefix.
Also removed all unnecessary error message processing to match java presto's output.
Removed unnecessary variables
Enable IPPREFIX cast test