refactor: Refactor spiller to have better abstraction #11656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
reviewed
Nov 26, 2024
731e76d to
dda16b6
Compare
xiaoxmeng
reviewed
Dec 26, 2024
| std::vector<SpillRun> spillRuns_; | ||
|
|
||
| private: | ||
| std::unique_ptr<SpillStatus> writeSpill(int32_t partition); |
There was a problem hiding this comment.
Can you keep the original comment?
xiaoxmeng
reviewed
Dec 26, 2024
dda16b6 to
47a42ce
Compare
xiaoxmeng
reviewed
Dec 27, 2024
xiaoxmeng
reviewed
Dec 27, 2024
47a42ce to
27e7817
Compare
xiaoxmeng
approved these changes
Dec 27, 2024
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
a7cb54f to
b0101b1
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
b0101b1 to
ec4dad9
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…tor#11656) Summary: Spiller is a single class dealing with multiple different spilling scenarios. We want to abstract out Spiller and make its implementations closer to its use sites and expose different use case APIs. Reviewed By: xiaoxmeng Differential Revision: D67666563 Pulled By: tanjialiang
ec4dad9 to
dfd45b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67666563 |
|
@tanjialiang merged this pull request in f973c65. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…tor#11656) Summary: Spiller is a single class dealing with multiple different spilling scenarios. We want to abstract out Spiller and make its implementations closer to its use sites and expose different use case APIs. Pull Request resolved: facebookincubator#11656 Reviewed By: xiaoxmeng Differential Revision: D67666563 Pulled By: tanjialiang fbshipit-source-id: 66c5cfc307e248f00c1ad871409023f05d0da4d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spiller is a single class dealing with multiple different spilling scenarios. We want to abstract out Spiller and make its implementations closer to its use sites and expose different use case APIs.