feat: Update throttler to support network signal #11611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 21, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Differential Revision: D66272632
480786f to
80a8443
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 21, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Differential Revision: D66272632
80a8443 to
2ed5751
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 21, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: arhimondr Differential Revision: D66272632
2ed5751 to
29e9e78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 21, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: arhimondr Differential Revision: D66272632
29e9e78 to
8147821
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 21, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: arhimondr Differential Revision: D66272632
8147821 to
8cc4f48
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
xiaoxmeng
approved these changes
Nov 25, 2024
8cc4f48 to
752cc03
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 25, 2024
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: xiaoxmeng, arhimondr Differential Revision: D66272632
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
…1611) Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: xiaoxmeng, arhimondr Differential Revision: D66272632
752cc03 to
9274a0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66272632 |
|
This pull request has been merged in c395c55. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
TongWei1105
pushed a commit
to TongWei1105/velox
that referenced
this pull request
Dec 3, 2024
…1611) Summary: Pull Request resolved: facebookincubator#11611 Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: xiaoxmeng, arhimondr Differential Revision: D66272632 fbshipit-source-id: 32e7de28fad8aea68c51d3e214fbfc831c799696
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…1611) Summary: Pull Request resolved: facebookincubator#11611 Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff Reviewed By: xiaoxmeng, arhimondr Differential Revision: D66272632 fbshipit-source-id: 32e7de28fad8aea68c51d3e214fbfc831c799696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Storage systems may return a network signal telling us that the backbone has transient issues. We should respect this signal and backoff