Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TTL in directories #11498

Closed

Conversation

yuandagits
Copy link
Contributor

Summary: Support TTL for directories

Differential Revision: D65734798

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 0722759
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67353687e8c8780008b9d86a

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 11, 2024
Summary:

Support TTL for directories

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 11, 2024
Summary:

Support TTL for directories

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 11, 2024
Summary:

Support TTL for directories

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 11, 2024
Summary:

Support TTL for directories

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

yuandagits added a commit to yuandagits/velox that referenced this pull request Nov 13, 2024
Summary:

Support TTL for directories

Reviewed By: xiaoxmeng

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuandagits LGTM. thanks!

Summary:

Support TTL for directories

Reviewed By: xiaoxmeng

Differential Revision: D65734798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65734798

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 427ac31.

Copy link

Conbench analyzed the 1 benchmark run on commit 427ac31e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
Summary:
Pull Request resolved: facebookincubator#11498

Support TTL for directories

Reviewed By: xiaoxmeng

Differential Revision: D65734798

fbshipit-source-id: 5082797b1fe82da495e2161514b2bdda118c724c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants