Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test ssdWriteOptions #11491

Closed

Conversation

zacw7
Copy link
Contributor

@zacw7 zacw7 commented Nov 10, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2024
Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a69ab8f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67310b6721ecf300075d220d

@zacw7 zacw7 force-pushed the fix-flaky-ssdwriteoptions branch 2 times, most recently from 3581ede to 39370fb Compare November 10, 2024 17:13
@zacw7 zacw7 force-pushed the fix-flaky-ssdwriteoptions branch from fcb2aae to a69ab8f Compare November 10, 2024 19:37
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacw7 thanks!

@zacw7 zacw7 marked this pull request as ready for review November 11, 2024 06:28
@zacw7 zacw7 requested a review from majetideepak as a code owner November 11, 2024 06:28
@facebook-github-bot
Copy link
Contributor

@zacw7 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zacw7 merged this pull request in 57040fd.

@zacw7 zacw7 deleted the fix-flaky-ssdwriteoptions branch November 11, 2024 07:57
Copy link

Conbench analyzed the 1 benchmark run on commit 57040fd7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11491

Reviewed By: xiaoxmeng

Differential Revision: D65739871

Pulled By: zacw7

fbshipit-source-id: 9145df9aa15c5408a8cc4323adf073372de55909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants