feat: Add ipprefix cast operators for ipaddr [2/n] #11481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Differential Revision: D65641994
9e09303 to
c52575c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Differential Revision: D65641994
c52575c to
2396dc2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
mohsaka
suggested changes
Nov 8, 2024
There was a problem hiding this comment.
You can take a look at my updated PRs with addressed comments.
https://github.com/facebookincubator/velox/pull/11309/files
https://github.com/facebookincubator/velox/pull/11378/files
Also here is the functions one if you are doing that too
#11407
Will be going on vacation so feel free to get yours merged!👍
thanks! I wasn't aware of your PRs 😅, I will take a look at your pointers |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 8, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
2396dc2 to
ec7ed79
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
ec7ed79 to
5b03b71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
5b03b71 to
90d17b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Nov 12, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
90d17b2 to
dccca64
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 3, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
60d7952 to
6498e66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
6498e66 to
a4d3fa5
Compare
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 4, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
Yuhta
reviewed
Dec 4, 2024
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 5, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
a4d3fa5 to
e1045ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 5, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
e1045ee to
2df740f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 5, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
2df740f to
53f22ed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Dec 5, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Differential Revision: D65641994
Yuhta
approved these changes
Dec 5, 2024
Summary: Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Reviewed By: Yuhta Differential Revision: D65641994
53f22ed to
6edf852
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65641994 |
|
This pull request has been merged in 7205403. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11481 Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix. We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped. Also applies suggestion from https://github.com/facebookincubator/velox/pull/11309/files Reviewed By: Yuhta Differential Revision: D65641994 fbshipit-source-id: aa43e1667affd73f263fedb33a101bc6aff7dea7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support casting ipprefix -> ipaddress, and ipaddress -> ipprefix.
We just need one new helper function, tryIpPrefixLengthFromIPAddressType, which takes in int128_t, gets the ippaddress, and then we check if the ippaddress is ipv4 or ipv6 mapped. We return 32 for ipv4 and 128 for ipv6 mapped.
Differential Revision: D65641994