Add HashAggregation Replayer #11176
Closed
Add HashAggregation Replayer #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
e332b68 to
204b90a
Compare
xiaoxmeng
approved these changes
Oct 7, 2024
| static std::string usage(); | ||
|
|
||
| protected: | ||
| virtual core::PlanNodePtr createPlan() const = 0; | ||
| private: |
| const auto* replayNode = core::PlanNode::findFirstNode( | ||
| planFragment_.get(), | ||
| [this](const core::PlanNode* node) { return node->id() == nodeId_; }); | ||
| const auto traceRoot = fmt::format("{}/{}", rootDir_, taskId_); |
| static core::PlanNodePtr createTableWrtierNode( | ||
| const core::TableWriteNode* node, | ||
| const std::string& targetDir, | ||
| core::PlanNodePtr createRepalyNode( |
There was a problem hiding this comment.
s/createRepalyNode/createPlanNode/
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 74c2133. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Records input in `HashAggregation` and AggregationReplayer to support the replaying. part of facebookincubator#9668 Pull Request resolved: facebookincubator#11176 Reviewed By: tanjialiang Differential Revision: D64017836 Pulled By: xiaoxmeng fbshipit-source-id: 4392e511fb889dfc232eaf64c7228655c50d623f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records input in
HashAggregationand AggregationReplayer to support the replaying.part of #9668