Support custom comparison in Map Aggregations #11124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63570186 |
|
This pull request was exported from Phabricator. Differential Revision: D63570186 |
122b687 to
c8084f7
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Sep 30, 2024
Summary: Pull Request resolved: facebookincubator#11124 Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. Differential Revision: D63570186
Summary: Pull Request resolved: facebookincubator#11124 Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. Differential Revision: D63570186
|
This pull request was exported from Phabricator. Differential Revision: D63570186 |
c8084f7 to
c877703
Compare
xiaoxmeng
approved these changes
Sep 30, 2024
|
This pull request has been merged in 6911494. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
|
This pull request has been reverted by 813cfb8. |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 2, 2024
Summary: This is a second attempt to land the changes in facebookincubator#11124 The original description: Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. New context: I landed this along with facebookincubator#11119 so it got reverted along with it. This particular change did not introduce any issues though. Differential Revision: D63796041
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 2, 2024
…cubator#11155) Summary: This is a second attempt to land the changes in facebookincubator#11124 The original description: Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. New context: I landed this along with facebookincubator#11119 so it got reverted along with it. This particular change did not introduce any issues though. Differential Revision: D63796041
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 2, 2024
…cubator#11155) Summary: This is a second attempt to land the changes in facebookincubator#11124 The original description: Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. New context: I landed this along with facebookincubator#11119 so it got reverted along with it. This particular change did not introduce any issues though. Differential Revision: D63796041
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Summary: Pull Request resolved: #11155 This is a second attempt to land the changes in #11124 The original description: Building on #11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. New context: I landed this along with #11119 so it got reverted along with it. This particular change did not introduce any issues though. Reviewed By: xiaoxmeng Differential Revision: D63796041 fbshipit-source-id: 06e7ed5e5f62e8671341c6b938429aa05b23c177
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Pull Request resolved: facebookincubator#11124 Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. Reviewed By: xiaoxmeng Differential Revision: D63570186 fbshipit-source-id: a1b11d851585486480ef31a1c7e0c3d6672ac1b1
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…cubator#11155) Summary: Pull Request resolved: facebookincubator#11155 This is a second attempt to land the changes in facebookincubator#11124 The original description: Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in the map aggregations map_agg and map_union. Note that I did not add support in map_union_sum because it currently only supports Maps with a fixed set of key types, and none of those provide custom comparisons. New context: I landed this along with facebookincubator#11119 so it got reverted along with it. This particular change did not introduce any issues though. Reviewed By: xiaoxmeng Differential Revision: D63796041 fbshipit-source-id: 06e7ed5e5f62e8671341c6b938429aa05b23c177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Building on #11021 this adds support
for custom comparison functions provided by custom types in the map aggregations
map_agg and map_union.
Note that I did not add support in map_union_sum because it currently only supports
Maps with a fixed set of key types, and none of those provide custom comparisons.
Differential Revision: D63570186