Fix skip custom escape #11091
Closed
Fix skip custom escape #11091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
393adc4 to
6be7d5a
Compare
JkSelf
approved these changes
Sep 25, 2024
|
@Yuhta @mbasmanova Please help to import this PR. |
Yuhta
approved these changes
Sep 25, 2024
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 50784a5. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary:
Fix csutom escape char for substrings-search in constant like pattern.
The exsit ut has covered the custom-escape case but escape char '#' is just not supported by substrings-search
```
testLike("%cd", "%#%%", '#', true);
testLike("cde", "%#%%", '#', false);
```
Add ut to cover the case:
```
testLike("///__", "%//%/%", '/', false);
```
Pull Request resolved: facebookincubator#11091
Reviewed By: Yuhta, amitkdutta
Differential Revision: D63395708
Pulled By: kagamiori
fbshipit-source-id: e5eb651695f27fe5ff88b72963aa70d4a550ba7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix csutom escape char for substrings-search in constant like pattern.
The exsit ut has covered the custom-escape case but escape char '#' is just not supported by substrings-search
Add ut to cover the case: