Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade FBOS dependencies to 2024.09.16.00 (#11018)" #11079

Closed

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Sep 24, 2024

This reverts commit 6d1fbf0.
and
This reverts commit 0dd3a5d.

I validated locally that reverting this commit fixes the velox_functions_remote_client_test failure.
Resolves #11071

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit a7336ed
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66f598cd1a0f7f0008a7b0bd

@majetideepak
Copy link
Collaborator Author

@czentgr I feel we must revert this PR to unblock CI. The investigation of the sigsegv is taking longer than I anticipated.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 20b335b.

@majetideepak majetideepak deleted the revert-fb-os branch September 30, 2024 17:21
athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
…#11018)" (facebookincubator#11079)

Summary:
This reverts commit 6d1fbf0.

I validated locally that reverting this commit fixes the velox_functions_remote_client_test failure.
Resolves facebookincubator#11071

Pull Request resolved: facebookincubator#11079

Reviewed By: kgpai

Differential Revision: D63323399

Pulled By: pedroerp

fbshipit-source-id: a239066f542e3b4867add87a5418c81b7fd3020f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velox_functions_remote_client_test is failing in Linux release with adapters CI
3 participants