Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrow in CMake dependency README #11054

Closed
wants to merge 1 commit into from
Closed

Add arrow in CMake dependency README #11054

wants to merge 1 commit into from
+2 −1

Conversation

zuyu
Copy link
Contributor

@zuyu zuyu commented Sep 21, 2024 •
edited
Loading

#9992 adds arrow as a dependency, and this PR adds arrow in CMake dependency README.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 21, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 21, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d742df4
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/670d9fa62174030008c9f89e

@zuyu
Copy link
Contributor Author

zuyu commented Sep 23, 2024

@majetideepak could u plz take a look? Ty!

@zuyu zuyu requested a review from majetideepak September 24, 2024 01:32
@zuyu
Add arrow in CMake dependency README
Loading
Loading status checks…
d742df4
@zuyu zuyu force-pushed the cmake-dep-readme branch from 2f689ba to d742df4 Compare October 14, 2024 22:48
@zuyu zuyu requested a review from assignUser as a code owner October 14, 2024 22:48
@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in 671356a.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 671356a2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@zuyu zuyu deleted the cmake-dep-readme branch October 21, 2024 19:29
athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@zuyu @athmaja-n
Add arrow in CMake dependency README (facebookincubator#11054)
496cf5f 
Summary:
facebookincubator#9992 adds `arrow` as a dependency, and this PR adds `arrow` in CMake dependency README.

Pull Request resolved: facebookincubator#11054

Reviewed By: xiaoxmeng

Differential Revision: D64520314

Pulled By: kgpai

fbshipit-source-id: 8bb29eabe39833f45f57757ed2de65a46be3a8ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak

@assignUser assignUser

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zuyu @facebook-github-bot @majetideepak