Fix date_diff() bug across time zone boundaries #11053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63159202 |
|
This pull request was exported from Phabricator. Differential Revision: D63159202 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Sep 21, 2024
) Summary: Pull Request resolved: facebookincubator#11053 Date diff calculation for timestamp with time zone types need to be performed in the time zone of the first parameter to follow Presto's semantic. Timestamp calculation normalized to UTC may not return the same result if the interval crosses a daylight savings time. Differential Revision: D63159202
0c7546d to
9907f4b
Compare
) Summary: Pull Request resolved: facebookincubator#11053 Date diff calculation for timestamp with time zone types need to be performed in the time zone of the first parameter to follow Presto's semantic. Timestamp calculation normalized to UTC may not return the same result if the interval crosses a daylight savings time. Differential Revision: D63159202
|
This pull request was exported from Phabricator. Differential Revision: D63159202 |
9907f4b to
4009e6d
Compare
|
This pull request has been merged in 4e45bc5. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
) Summary: Pull Request resolved: facebookincubator#11053 Date diff calculation for timestamp with time zone types need to be performed in the time zone of the first parameter to follow Presto's semantic. Timestamp calculation normalized to UTC may not return the same result if the interval crosses a daylight savings time. Reviewed By: amitkdutta, kgpai Differential Revision: D63159202 fbshipit-source-id: fb8eaf10dc6e8ab14e8eb635ff64ce2be4939823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Date diff calculation for timestamp with time zone types need to be
performed in the time zone of the first parameter to follow Presto's semantic.
Timestamp calculation normalized to UTC may not return the same result if the
interval crosses a daylight savings time.
Differential Revision: D63159202