Provide custom comparison functions in TimestampWithTimezone #11025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D62906383 |
✅ Deploy Preview for meta-velox canceled.
|
pansatadru
approved these changes
Sep 20, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62906383 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Sep 25, 2024
…kincubator#11025) Summary: Pull Request resolved: facebookincubator#11025 facebookincubator#11021 introduced the ability for custom types to provide their own compare and hash semantics. This change updates TimestampWithTimezone to take advantage of this new feature. It is represented as a 64-bit integer, but only the top 42 bits of the value, which represent the millis since epoch in UTC, should be used for the purposes of comparison and hashing. The bottom 12 bits which represent the timezone should be ignored. Reviewed By: pansatadru Differential Revision: D62906383
311f2cb to
90a5b04
Compare
…kincubator#11025) Summary: Pull Request resolved: facebookincubator#11025 facebookincubator#11021 introduced the ability for custom types to provide their own compare and hash semantics. This change updates TimestampWithTimezone to take advantage of this new feature. It is represented as a 64-bit integer, but only the top 42 bits of the value, which represent the millis since epoch in UTC, should be used for the purposes of comparison and hashing. The bottom 12 bits which represent the timezone should be ignored. Reviewed By: pansatadru Differential Revision: D62906383
|
This pull request was exported from Phabricator. Differential Revision: D62906383 |
90a5b04 to
bec8701
Compare
|
This pull request has been merged in 9e1280a. |
|
Conbench analyzed the 1 benchmark run on commit There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…kincubator#11025) Summary: Pull Request resolved: facebookincubator#11025 facebookincubator#11021 introduced the ability for custom types to provide their own compare and hash semantics. This change updates TimestampWithTimezone to take advantage of this new feature. It is represented as a 64-bit integer, but only the top 42 bits of the value, which represent the millis since epoch in UTC, should be used for the purposes of comparison and hashing. The bottom 12 bits which represent the timezone should be ignored. Reviewed By: pansatadru Differential Revision: D62906383 fbshipit-source-id: 93c5c4e9a1f8bf716d3b804f3bd7019d3b2b0ad3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#11021 introduced the ability for custom types to
provide their own compare and hash semantics.
This change updates TimestampWithTimezone to take advantage of this new feature. It is
represented as a 64-bit integer, but only the top 42 bits of the value, which represent the millis since
epoch in UTC, should be used for the purposes of comparison and hashing. The bottom 12 bits
which represent the timezone should be ignored.
Differential Revision: D62906383