Fix "wget: command not found" error when installing ccache #10995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
In "Install FMT and download ccache on MacOS (facebookincubator#10933)", wget was used to download ccache in setup-macos.sh. However, wget is not pre-installed on MacOs by default, and the following error was thrown: + wget -O ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.10.2/ccache-4.10.2-darwin.tar.gz ../scripts/setup-macos.sh: line 80: wget: command not found + tar -xf ccache.tar.gz tar: Error opening archive: Failed to open 'ccache.tar.gz' This commit changes wget to curl, which is guaranteed to be pre-installed on MacOS.
|
@majetideepak @assignUser @kgpai Can you please review? Thanks! |
assignUser
approved these changes
Sep 13, 2024
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kevinwilfong merged this pull request in 17eb5a1. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ncubator#10995) Summary: In "Install FMT and download ccache on MacOS (facebookincubator#10933)", wget was used to download ccache in setup-macos.sh. However, wget is not pre-installed on MacOs by default, and the following error was thrown: ``` + wget -O ccache.tar.gz https://github.com/ccache/ccache/releases/download/v4.10.2/ccache-4.10.2-darwin.tar.gz ../scripts/setup-macos.sh: line 80: wget: command not found + tar -xf ccache.tar.gz tar: Error opening archive: Failed to open 'ccache.tar.gz' ``` This commit changes wget to curl, which is guaranteed to be pre-installed on MacOS. Pull Request resolved: facebookincubator#10995 Reviewed By: pedroerp Differential Revision: D62646279 Pulled By: kevinwilfong fbshipit-source-id: aaa2365ae013bb012f25556d4741e3a08ea7ef82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "Install FMT and download ccache on MacOS (#10933)", wget was used to download ccache in setup-macos.sh. However, wget is not pre-installed on MacOs by default, and the following error was thrown:
This commit changes wget to curl, which is guaranteed to be pre-installed on MacOS.