Add trace support for TableWriter #10910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
2363373 to
3818fd9
Compare
3818fd9 to
08a2264
Compare
6cbfc3e to
3ab77ee
Compare
xiaoxmeng
reviewed
Sep 25, 2024
velox/exec/Task.cpp
Outdated
| const auto queryTraceNodes = queryConfig.queryTraceNodeIds(); | ||
| if (queryTraceNodes.empty()) { | ||
| return trace::QueryTraceConfig(queryConfig.queryTraceDir()); | ||
| LOG(WARNING) << "Query trace is enabled, but no nodes will be traced."; |
There was a problem hiding this comment.
Query metadata trace enabled
velox/exec/Task.cpp
Outdated
| return trace::QueryTraceConfig(traceDir); | ||
| } | ||
| if (queryConfig.queryTraceMaxBytes() == 0) { | ||
| LOG(WARNING) |
There was a problem hiding this comment.
Let's just check in tracing path?
4bedead to
c82b5cd
Compare
xiaoxmeng
reviewed
Sep 26, 2024
velox/exec/Task.cpp
Outdated
| @@ -2855,10 +2855,13 @@ std::optional<trace::QueryTraceConfig> Task::maybeMakeTraceConfig() const { | |||
| if (!RE2::FullMatch(taskId_, queryConfig.queryTraceTaskRegExp())) { | |||
| return std::nullopt; | |||
| } | |||
| LOG(INFO) << "Query metadata trace enabled in task: " << taskId_; | |||
There was a problem hiding this comment.
Let's just remove metadata trace only use case? Thanks!
Trace query metadata for task: <<
c82b5cd to
2b0ed98
Compare
xiaoxmeng
reviewed
Sep 26, 2024
velox/exec/Operator.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| if (operatorCtx_->driverCtx()->queryConfig().queryTraceMaxBytes() == 0) { |
There was a problem hiding this comment.
Check queryTraceMaxBytes first?
xiaoxmeng
reviewed
Sep 26, 2024
a83758d to
fd1f5e6
Compare
xiaoxmeng
reviewed
Sep 26, 2024
velox/exec/Operator.cpp
Outdated
|
|
||
| const auto pipelineId = operatorCtx_->driverCtx()->pipelineId; | ||
| const auto driverId = operatorCtx_->driverCtx()->driverId; | ||
| LOG(INFO) << "Query data trace enabled in operator: " << operatorType() |
There was a problem hiding this comment.
Trace data for operator type: operatorType(), op id: , pipeline, driver:
fd1f5e6 to
c7448ff
Compare
c7448ff to
36074cc
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 3fe248f. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: Create a `QueryDataWriter` in `exec::TableWriter` if the query trace is enabled, recording the input vectors batch by batch. Each operator writes its data to the directory `$rootDir/$pipelineId/$driverId/data`. The recorded data will be used to replay the execution of `exec::TableWriter`, which will be supported in the follow-up. Design notes: https://docs.google.com/document/d/1crIIeVz4tWKYQnBoHoxrv2i-4zAML9HSYLps8h5SDrc/edit#heading=h.y6j2ojtr7hm9 Part of facebookincubator#9668 Pull Request resolved: facebookincubator#10910 Reviewed By: pedroerp Differential Revision: D63444416 Pulled By: xiaoxmeng fbshipit-source-id: ddd74ff6dd56de7bce31ec536035b32211453364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
QueryDataWriterinexec::TableWriterif the query trace is enabled,recording the input vectors batch by batch. Each operator writes its data to the
directory
$rootDir/$pipelineId/$driverId/data. The recorded data will be usedto replay the execution of
exec::TableWriter, which will be supported in thefollow-up.
Design notes: https://docs.google.com/document/d/1crIIeVz4tWKYQnBoHoxrv2i-4zAML9HSYLps8h5SDrc/edit#heading=h.y6j2ojtr7hm9
Part of #9668