Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batch version of RowContainer::store API #10812

Closed
wants to merge 3 commits into from
Closed

Add batch version of RowContainer::store API #10812

wants to merge 3 commits into from

Conversation

zhli1142015
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c63c038
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66d9a223fda2620008d4057c

@zhli1142015 zhli1142015 mentioned this pull request Aug 22, 2024
Closed
mbasmanova
mbasmanova reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhli1142015 Nice refactoring. Overall looks good % some nits and comments on the test.

velox/exec/RowContainer.h Outdated Show resolved Hide resolved
velox/exec/RowContainer.cpp Outdated Show resolved Hide resolved
velox/exec/RowContainer.cpp Outdated Show resolved Hide resolved
velox/exec/tests/RowContainerTest.cpp Outdated Show resolved Hide resolved
@mbasmanova mbasmanova changed the title Add storeVector API for RowContainer Add batch version of RowContainer::store API Aug 22, 2024
mbasmanova
mbasmanova approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhli1142015 Looks good. Thanks.

velox/exec/tests/RowContainerTest.cpp Outdated Show resolved Hide resolved
@mbasmanova mbasmanova added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Aug 22, 2024
@zhli1142015
Copy link
Contributor Author

@kgpai, could you please help merge this PR?
Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhli1142015
Copy link
Contributor Author

Hello @kgpai and @bikramSingh91,
Could you please help re-trigger the Meta CI jobs and merge this PR?
Thanks.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhli1142015
Copy link
Contributor Author

Thanks @kgpai for helping to trigger the CI , is it ok to merge this PR, or is there any thing from internal CI I need to fix?

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in de734a0.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit de734a0b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@zhli1142015 @athmaja-n
Add batch version of RowContainer::store API (facebookincubator#10812)
08d23ed 
Summary: Pull Request resolved: facebookincubator#10812

Reviewed By: xiaoxmeng, DanielHunte

Differential Revision: D61924803

Pulled By: kgpai

fbshipit-source-id: f6fbab99e40d1d423aecc24f91b47059a73ba98d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhli1142015 @facebook-github-bot @mbasmanova