Deprecate old core::Config class #10716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ded7c3a to
764a949
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
764a949 to
ea436ca
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ea436ca to
35650e9
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
35650e9 to
0f26731
Compare
|
@tanjialiang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
0f26731 to
a965d25
Compare
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 13, 2024
Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 13, 2024
Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
a965d25 to
b06c2da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 13, 2024
Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
b06c2da to
012e644
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 13, 2024
…ubator#10716) Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
012e644 to
0d216ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
tanjialiang
added a commit
to tanjialiang/velox-1
that referenced
this pull request
Aug 13, 2024
…ubator#10716) Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
0d216ab to
2fc0b34
Compare
…ubator#10716) Summary: As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean Pull Request resolved: facebookincubator#10716 Reviewed By: xiaoxmeng Differential Revision: D61147922 Pulled By: tanjialiang
2fc0b34 to
490e58a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61147922 |
|
@tanjialiang merged this pull request in 3ef1d61. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the consolidating and polishing config effort, all configs should now utilize common/config/Config.h as it provides richer functionality. Deprecate the old one to make the codebase clean